Metamist release #554
Merged
Metamist release #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing npm run compile step in documentation and fix the spellin…
* Improve set-up documentation + aux changes Signed-off-by: Michael Franklin <illusional@users.noreply.github.com> * Fix default ped path for generate_data * Apply review feedback * Sneaky sneaky --------- Signed-off-by: Michael Franklin <illusional@users.noreply.github.com> Co-authored-by: Michael Franklin <illusional@users.noreply.github.com>
* Add set default role in instructions Missed step from me, not sure why it worked initially, but it definitely didn't work without it * Add more semicolons
* Address mypy errors * More linting updates * Two tests to fix checks * Rejig lint to build package to mypy scripts * Add strawberry[debug-server] requirement * Revert to the OpenApiGenNoneType for tests * Add extra import --------- Co-authored-by: Michael Franklin <illusional@users.noreply.github.com>
* Add participant phenotypes to graphql * Add test for graphql phenotypes * Fix unrelated linting issues * Slight linting updates * PR cleanup --------- Co-authored-by: Michael Franklin <illusional@users.noreply.github.com>
Prevent "The following action(s) uses node12 which is deprecated" warnings by updating to the current releases of the Actions used. (Node.js 12 is scheduled for removal from Actions runners next month.) Use the current releases instead of `@main` too, as we don't want to be affected by bleeding-edge bugs. Rewrite ::set-output as a write to $GITHUB_OUTPUT instead; the ::save-state and ::set-output commands are also deprecated.
EddieLF
reviewed
Sep 20, 2023
| @@ -189,6 +189,7 @@ def _project_summary_process_sample_rows( | |||
| created_date=str(sample_id_start_times.get(s['id'], '')), | |||
| sequencing_groups=sg_models_by_sample_id.get(s['id'], []), | |||
| non_sequencing_assays=filtered_assay_models_by_sid.get(s['id'], []), | |||
| active=bool(ord(s['active'])), | |||
There was a problem hiding this comment.
What exactly is happening here? Isn't s['active'] already a bool variable?
Not sure I understand why using ord() and bool() will work on this.
There was a problem hiding this comment.
Surprisingly not, encode/databases#347
There was a problem hiding this comment.
Interesting! 🤔 So in the schema the active field is a BOOLEAN type, which in MySQL is a synonym for TINYINT(1), which when returned comes out like BIT... so we need this conversion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #553 before merging