Log backtrace on sigsegv and sigbus signals #22
Conversation
|
I guess I should notify the next handler. Rust handles segfaults to detect and report stack overflows: rust-lang/rust#31333 |
To do this robustly we need a separate implementation for Windows and Unix so this doesn't seem worth it. I added a note about that. I also added a note about R's segfault handler. It doesn't override our handler because we set |
| // Register segfault handler to get a backtrace. Should be after | ||
| // initialising `log!`. Note that R will not override this handler | ||
| // because we set `R_SignalHandlers` to 0 before startup. | ||
| stdext::traps::register_trap_handlers(); |
There was a problem hiding this comment.
Do we want to disable this in release builds?
There was a problem hiding this comment.
Would there be a downside to leave it on? On the upside it could be useful for R developers to get a backtrace of their native code on crash.
There was a problem hiding this comment.
I think you're right -- let's leave it on.
lionel-
force-pushed
the
feature/sigsegv-backtrace
branch
from
d2b3aab
to
65b72a9
Compare
Requires posit-dev/positron#708 otherwise the backtrace doesn't show up.