add benchmarks for creating sourcemaps #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainmenke
commented
Sep 16, 2023
romainmenke
commented
Sep 16, 2023
ai
reviewed
Sep 16, 2023
| @@ -31,7 +31,7 @@ gulp.task('bootstrap', async () => { | |||
| }) | |||
| }) | |||
|
|
|||
| for (let name of ['preprocessors', 'parsers', 'prefixers', 'tokenizers', 'linters']) { | |||
| for (let name of ['preprocessors', 'parsers', 'prefixers', 'tokenizers', 'linters', 'sourcemaps']) { | |||
There was a problem hiding this comment.
Could you run Prettier (in VSCode or by installing it globally)?
We have an 80 columns limit.
There was a problem hiding this comment.
I tried with the VSCode extension and by installing globally but I couldn't get it to wrap these lines.
Is it possible that you have a global/default config for prettier?
There was a problem hiding this comment.
I have config in package.json.
Don’t worry, I will fix it after merging.
ai
reviewed
Sep 16, 2023
romainmenke
deleted the
add-benchmarks-for-sourcemaps--diligent-sumatran-elephant-fde243eacb
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sourcemap generation is not currently benchmarked but this is the slowest part of PostCSS.
Because it is a blindspot it is also harder to improve and to prevent regressions.