-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add benchmarks for creating sourcemaps #32
Merged
ai
merged 3 commits into
postcss:main
from
romainmenke:add-benchmarks-for-sourcemaps--diligent-sumatran-elephant-fde243eacb
Sep 18, 2023
Merged
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
/* Results on Node 20.3.1, Github Actions: | ||
|
||
PostCSS: 389 ms | ||
*/ | ||
|
||
let { existsSync, readFileSync } = require('fs') | ||
let { join } = require('path') | ||
const postcss = require('postcss') | ||
|
||
let example = join(__dirname, 'cache', 'bootstrap.css') | ||
let css = readFileSync(example).toString() | ||
|
||
module.exports = { | ||
maxTime: 15, | ||
name: 'Sourcemaps', | ||
tests: [ | ||
{ | ||
defer: true, | ||
fn: done => { | ||
{ | ||
romainmenke marked this conversation as resolved.
Show resolved
Hide resolved
|
||
let root = postcss.parse(css, { from: example }) | ||
root.toResult({ map: { inline: false }, to: 'dist/bootstrap.css' }).map.toJSON() | ||
} | ||
|
||
{ | ||
let root = postcss.parse(css, { from: example }) | ||
root.toResult({ map: { absolute: true, inline: false }, to: 'dist/bootstrap.css' }).map.toJSON() | ||
} | ||
|
||
{ | ||
let root = postcss.parse(css, { from: example }) | ||
root.toResult({ map: { inline: true }, to: 'dist/bootstrap.css' }) | ||
} | ||
romainmenke marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
done.resolve() | ||
}, | ||
name: 'PostCSS' | ||
} | ||
] | ||
} | ||
|
||
let devPath = join(__dirname, '../postcss/lib/postcss.js') | ||
if (existsSync(devPath)) { | ||
let devPostcss = require(devPath) | ||
module.exports.tests.splice(1, 0, { | ||
defer: true, | ||
fn: done => { | ||
{ | ||
let root = devPostcss.parse(css, { from: example }) | ||
root.toResult({ map: { inline: false }, to: 'dist/bootstrap.css' }).map.toJSON() | ||
} | ||
|
||
{ | ||
let root = devPostcss.parse(css, { from: example }) | ||
root.toResult({ map: { absolute: true, inline: false }, to: 'dist/bootstrap.css' }).map.toJSON() | ||
} | ||
|
||
{ | ||
let root = devPostcss.parse(css, { from: example }) | ||
root.toResult({ map: { inline: true }, to: 'dist/bootstrap.css' }) | ||
} | ||
|
||
done.resolve() | ||
}, | ||
name: 'Next PostCSS' | ||
}) | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you run Prettier (in VSCode or by installing it globally)?
We have an 80 columns limit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried with the VSCode extension and by installing globally but I couldn't get it to wrap these lines.
Is it possible that you have a global/default config for prettier?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have config in
package.json
.Don’t worry, I will fix it after merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you 🙇