Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add benchmarks for creating sourcemaps #32

Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ gulp.task('bootstrap', async () => {
})
})

for (let name of ['preprocessors', 'parsers', 'prefixers', 'tokenizers', 'linters']) {
for (let name of ['preprocessors', 'parsers', 'prefixers', 'tokenizers', 'linters', 'sourcemaps']) {
Copy link
Member

@ai ai Sep 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you run Prettier (in VSCode or by installing it globally)?

We have an 80 columns limit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried with the VSCode extension and by installing globally but I couldn't get it to wrap these lines.

Is it possible that you have a global/default config for prettier?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have config in package.json.

Don’t worry, I will fix it after merging.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you 🙇

gulp.task(
name,
gulp.series('bootstrap', () => {
Expand All @@ -47,5 +47,5 @@ for (let name of ['preprocessors', 'parsers', 'prefixers', 'tokenizers', 'linter

gulp.task(
'default',
gulp.series('preprocessors', 'parsers', 'prefixers', 'tokenizers', 'linters')
gulp.series('preprocessors', 'parsers', 'prefixers', 'tokenizers', 'linters', 'sourcemaps')
)
67 changes: 67 additions & 0 deletions sourcemaps.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
/* Results on Node 20.3.1, Github Actions:

PostCSS: 389 ms
*/

let { existsSync, readFileSync } = require('fs')
let { join } = require('path')
const postcss = require('postcss')

let example = join(__dirname, 'cache', 'bootstrap.css')
let css = readFileSync(example).toString()

module.exports = {
maxTime: 15,
name: 'Sourcemaps',
tests: [
{
defer: true,
fn: done => {
{
romainmenke marked this conversation as resolved.
Show resolved Hide resolved
let root = postcss.parse(css, { from: example })
root.toResult({ map: { inline: false }, to: 'dist/bootstrap.css' }).map.toJSON()
}

{
let root = postcss.parse(css, { from: example })
root.toResult({ map: { absolute: true, inline: false }, to: 'dist/bootstrap.css' }).map.toJSON()
}

{
let root = postcss.parse(css, { from: example })
root.toResult({ map: { inline: true }, to: 'dist/bootstrap.css' })
}
romainmenke marked this conversation as resolved.
Show resolved Hide resolved

done.resolve()
},
name: 'PostCSS'
}
]
}

let devPath = join(__dirname, '../postcss/lib/postcss.js')
if (existsSync(devPath)) {
let devPostcss = require(devPath)
module.exports.tests.splice(1, 0, {
defer: true,
fn: done => {
{
let root = devPostcss.parse(css, { from: example })
root.toResult({ map: { inline: false }, to: 'dist/bootstrap.css' }).map.toJSON()
}

{
let root = devPostcss.parse(css, { from: example })
root.toResult({ map: { absolute: true, inline: false }, to: 'dist/bootstrap.css' }).map.toJSON()
}

{
let root = devPostcss.parse(css, { from: example })
root.toResult({ map: { inline: true }, to: 'dist/bootstrap.css' })
}

done.resolve()
},
name: 'Next PostCSS'
})
}
Loading