Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use consistent strategies for tests #97

Merged
merged 6 commits into from
Dec 31, 2018
Merged

Use consistent strategies for tests #97

merged 6 commits into from
Dec 31, 2018

Conversation

nbraud
Copy link
Collaborator

@nbraud nbraud commented Dec 29, 2018

  • utils.vectors: Set the default max_magnitude to 10⁷⁵.
    No test uses a smaller value, and larger vectors are meaningless: the observable Universe is 9×10²⁶ meters across...
  • Introduce convenience strategies for angles and lengths.
    This should make it more obvious which inputs are what, and that should help with tests: Clarify the property-based tests #85.
  • Simplify utils.units.

@nbraud
Copy link
Collaborator Author

nbraud commented Dec 29, 2018

This is going to conflict hilariously with #85, but I don't care in which order it is merged.

@nbraud
Copy link
Collaborator Author

nbraud commented Dec 29, 2018

Actually, I merged all the in-flight pull requests in a temporary branch, and it wasn't too bad.
Still, it would be nice if we could move a bit towards closing/merging.

@AstraLuma AstraLuma merged commit d6bed0d into ppb:master Dec 31, 2018
@nbraud nbraud deleted the tests/strategies branch January 1, 2019 19:48
This was referenced Jan 1, 2019
Merged
Merged
nbraud added a commit to nbraud/ppb-vector that referenced this pull request Jan 3, 2019
@nbraud
tests/isclose: Limit the range on absolute tolerance tests
3ce31b6 
This removes a very-unlikely test failure, produced locally after running
Hypothesis almost a hundred times in CI profile.

This required pulling 24b206b from ppb#97.
nbraud added a commit to nbraud/ppb-vector that referenced this pull request Jan 3, 2019
@nbraud
tests/isclose: Limit the range on absolute tolerance tests
1d49c9d 
This removes a very-unlikely test failure, produced locally after running
Hypothesis almost a hundred times in CI profile.

This required pulling 24b206b from ppb#97.
@nbraud nbraud mentioned this pull request Jan 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbraud @AstraLuma