Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add negative tests for Vector2.isclose #99

Merged
merged 7 commits into from
Jan 3, 2019
Merged

Add negative tests for Vector2.isclose #99

merged 7 commits into from
Jan 3, 2019

Conversation

nbraud
Copy link
Collaborator

@nbraud nbraud commented Jan 2, 2019 •
edited
Loading

@nbraud
Copy link
Collaborator Author

nbraud commented Jan 2, 2019

The negative example for rel_tol is heavily commented because it was somewhat difficult to figure out.

@nbraud nbraud mentioned this pull request Jan 2, 2019
Merged
nbraud added 3 commits January 2, 2019 21:45
@nbraud
tests/isclose: Limit relative tolerance to [ε; 1-ε]
ce92fe8 
Larger values (allowing 100% error or more) do not make much sense.
Smaller values cause rounding errors because ε² is too small.
@nbraud
tests/isclose: Add a negative example for relative tolerance
3675d77
@nbraud
tests/isclose: Loosen the precision on the absolute tolerance test
8863032
@nbraud
Copy link
Collaborator Author

nbraud commented Jan 2, 2019 •
edited
Loading

I fixed the issue that broke CI for #101, so this should be good now.

@AstraLuma AstraLuma merged commit 872f573 into ppb:master Jan 3, 2019
@nbraud nbraud deleted the tests/isclose branch January 3, 2019 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbraud @AstraLuma