Flip Y Axis #237
Merged
Flip Y Axis #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was assuming that Vector.rotate() did an in-place mutation, which is not the case.
* Add facing setter * Remove redundant .rotate() definition
Co-Authored-By: astronouth7303 <jamie@ivyleav.es>
…pybear into immutable-vectors
Co-Authored-By: astronouth7303 <jamie@ivyleav.es>
|
Oh, this depends on #204. |
pathunstrom
reviewed
Apr 23, 2019
ppb/camera.py
Outdated
| def translate_to_viewport(self, point:Vector) -> Vector: | ||
| def translate_to_viewport(self, point: Vector) -> Vector: | ||
| """ | ||
| Converts a vector from in-game to PyGame coordinate space |
There was a problem hiding this comment.
This is more about screen space, not pygame specific (We'll have a similar pixel array context no matter which rendering library we use.)
There was a problem hiding this comment.
Umm... You don't have too? Taking to discord.
pathunstrom
approved these changes
Apr 24, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 5, 2019
237: Flip Y Axis r=pathunstrom a=astronouth7303 Per some discussions on discord, flip the Y axis so that PPB's concept of space & coordinates match those of traditional geometry & algebra. I think I'm going to write a full blog post explaining this. Co-authored-by: Jamie Bliss <jamie@ivyleav.es> Co-authored-by: Nicolas Braud-Santoni <nicolas@braud-santoni.eu>
Build succeeded
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per some discussions on discord, flip the Y axis so that PPB's concept of space & coordinates match those of traditional geometry & algebra.
I think I'm going to write a full blog post explaining this.