Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs sprites #471

Merged
merged 11 commits into from
May 22, 2020
Merged

Docs sprites #471

merged 11 commits into from
May 22, 2020

Conversation

pathunstrom
Copy link
Collaborator

No description provided.

@pathunstrom pathunstrom marked this pull request as ready for review May 15, 2020 23:08
@pathunstrom pathunstrom requested a review from a team as a code owner May 15, 2020 23:08
AstraLuma
AstraLuma requested changes May 18, 2020
View reviewed changes
ppb/sprites.py Outdated Show resolved Hide resolved
ppb/sprites.py Outdated Show resolved Hide resolved
ppb/sprites.py Outdated Show resolved Hide resolved
ppb/sprites.py Outdated Show resolved Hide resolved
ppb/sprites.py Outdated Show resolved Hide resolved
ppb/sprites.py Outdated Show resolved Hide resolved
ppb/sprites.py Outdated Show resolved Hide resolved
ppb/sprites.py Outdated Show resolved Hide resolved
ppb/sprites.py Outdated Show resolved Hide resolved
ppb/sprites.py Outdated Show resolved Hide resolved
@AstraLuma AstraLuma mentioned this pull request May 18, 2020
Merged
pathunstrom
pathunstrom commented May 22, 2020
View reviewed changes
ppb/sprites.py Outdated Show resolved Hide resolved
AstraLuma
AstraLuma approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@AstraLuma AstraLuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented May 22, 2020

Build succeeded:

@bors bors bot merged commit 0525ffa into ppb:master May 22, 2020
bors bot added a commit that referenced this pull request May 22, 2020
@bors @AstraLuma
Merge #476
755f088 
476: Have CI sphinx treat warnings as errors r=pathunstrom a=astronouth7303

We're accumulating sphinx warnings, which usually means that sphinx is doing something wacky in the generated output.

Have the CI docs check treat these as errors so they don't get into the code.

Depends on #471.

Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
bors bot added a commit that referenced this pull request May 23, 2020
@bors @AstraLuma
Merge #476
af18ec2 
476: Have CI sphinx treat warnings as errors r=pathunstrom a=astronouth7303

We're accumulating sphinx warnings, which usually means that sphinx is doing something wacky in the generated output.

Have the CI docs check treat these as errors so they don't get into the code.

Depends on #471.

Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
@pathunstrom pathunstrom deleted the docs-sprites branch October 24, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AstraLuma AstraLuma AstraLuma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pathunstrom @AstraLuma