Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have CI sphinx treat warnings as errors #476

Merged
merged 7 commits into from
May 23, 2020
Merged

Conversation

AstraLuma
Copy link
Member

@AstraLuma AstraLuma commented May 18, 2020

We're accumulating sphinx warnings, which usually means that sphinx is doing something wacky in the generated output.

Have the CI docs check treat these as errors so they don't get into the code.

Depends on #471.

@AstraLuma AstraLuma requested a review from a team as a code owner May 18, 2020 16:44
@AstraLuma
Copy link
Member Author

@pathunstrom this seems ready

Copy link
Collaborator

@pathunstrom pathunstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request May 22, 2020
476: Have CI sphinx treat warnings as errors r=pathunstrom a=astronouth7303

We're accumulating sphinx warnings, which usually means that sphinx is doing something wacky in the generated output.

Have the CI docs check treat these as errors so they don't get into the code.

Depends on #471.

Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
@pathunstrom
Copy link
Collaborator

bors retry

@pathunstrom
Copy link
Collaborator

bors cancel

@bors bors bot merged commit af18ec2 into ppb:master May 23, 2020
@AstraLuma AstraLuma deleted the sphinx-strict branch October 16, 2020 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants