Work around DirectX libraries blocking iOS from building #5592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now consumers don't have to carry around any workarounds we add to our libraries, as they're automatically applied during build using the `osu.Framework.iOS.Workarounds.targets` file.
smoogipoo
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt number 2, this time with not too extreme changes (see #5590 for previous approach).
Vortice.Direct3D11and other DirectX libraries rely onSharpGen.Runtimefor bindings generation, which makes it referenced during framework building stage, but fail on iOS during AOT compilation for unknown reasons.I've went ahead and compiled empty assemblies for the faulty libraries and set up a target to copy the assemblies to the linking folder, while expecting it to fail due to the assemblies being... well, empty. But luckily enough, it passed AOT stage and finished building successfully.