Update framework #21629
Update framework #21629
Conversation
|
This one's going to require the fixes to be applied for android (and potentially iOS) as a result of framework-side changes. |
I haven't found a way to disable LLVM, and the issue may potentially be resolved (doesn't occur for me), so we might as well just remove the key for now.
peppy
force-pushed
the
guard-url-protocols
branch
from
8cdb332
to
dd9a418
Compare
|
@frenzibyte i'll leave the mobile projects to you to figure out. looks like the |
|
Should be fixed now, looks to be happening due to GH actions not yet using Xcode 14.1, so I've had to manually pin it to do so. See actions/runner-images#6771 for more information. |
frenzibyte
force-pushed
the
guard-url-protocols
branch
from
3cfcc1c
to
4dbc1c3
Compare
peppy
force-pushed
the
guard-url-protocols
branch
from
b9908d7
to
4a7d7c6
Compare
|
There's a theory that this may be ready to go now, if CI passes. @smoogipoo would appreciate a one-over (feel free to apply any changes you deem necessary directly). |
|
Wanna wait for new o!f package with ppy/osu-framework#5592 before merging this one? |
|
Well this one works fine as-is, since none of the veldrid stuff is in. So I figure it's best to review / merge this first then we'll do a second bump. But if you'd rather do it all at once I'm fine with that too. |
| "sdk": { | ||
| "version": "6.0.300", | ||
| "rollForward": "major" | ||
| } |
There was a problem hiding this comment.
This was removed in #17462 but still exists here, was that intentional?
There was a problem hiding this comment.
Was an oversight, I'll pull it into a follow-up branch I have.
Includes required changes for new URL safeties.