Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiplayer scores being submitted as pass even if failed #26384

Merged
merged 5 commits into from
Jan 4, 2024
Merged

Fix multiplayer scores being submitted as pass even if failed #26384

merged 5 commits into from
Jan 4, 2024

Conversation

peppy
Copy link
Sponsor Member

@peppy peppy commented Jan 4, 2024 •
edited
Loading

Caveats:

Apart from this, seems to work okay.

@peppy peppy changed the title Fix multiplayer fail online submit Fix multiplayer scores being submitted as pass even if failed Jan 4, 2024
@peppy peppy added blocked Don't merge this. area:multiplayer next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! and removed blocked Don't merge this. labels Jan 4, 2024
@peppy peppy requested a review from a team January 4, 2024 08:50
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 4, 2024
@smoogipoo smoogipoo merged commit 8e6f652 into ppy:master Jan 4, 2024
15 of 17 checks passed
@bdach bdach mentioned this pull request Jan 4, 2024
Closed
@peppy peppy deleted the fix-multiplayer-fail-online-submit branch January 12, 2024 19:50
@frenzibyte frenzibyte mentioned this pull request Jan 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoogipoo smoogipoo smoogipoo approved these changes

Assignees
No one assigned
Labels
area:multiplayer next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peppy @smoogipoo