Fix score processor no longer applying results when failing in multiplayer match

[frenzibyte]

• Closes Score/accuracy/combo freezes on multiplayer match after reaching a fail state #26670

This happens because ScoreProcessor completely stops accepts any judgement when health goes to zero (determined by HealthProcessor.HasFailed). As far as I understand, the intention of this behaviour is to match stable and also because it's simply logical (score shouldn't increase when player fails).

Testing wise, the logic of ensuring that normal player instances stop applying results after reaching a fail state is already covered by TestSceneFailJudgement, but I've added another test case specific to MultiplayerPlayer ensuring that results still affect score after reaching a fail state.

[bdach]

I disagree so much with this change and everything it implies.

Any gameplay logic being conditional on "being shown the fail animation" is completely and utterly wrong.

This feels like going in a completely off-base direction. And I think the fix to this entire issue should be local to the multiplayer flow, because it's the one stretching the definition of "fail" to begin with.

[frenzibyte]

I approached this initially with the thought that Player has two separate states of failing, each being:

1. marking score as failed / F rank (determined by HealthProcessor.HasFailed)
2. presenting fail animation and stopping gameplay (determined by GameplayState.HasFailed, never set to true in multiplayer since Fix multiplayer scores being submitted as pass even if failed #26384).

Therefore I've went with renaming GameplayState.HasFailed to the name in the diff of this conversation, as well as using that state for whether the judgement processors should no longer apply new results.

I will be honest that I didn't pay enough attention at the diff and missed the fact that GameplayState.HasFailed is used in more places than usual, and having the name specifically referring to "presence of fail animation" is indeed sketchy.

I could use better names such as HasStoppedDueToFail, but I've went ahead with your alternative proposal in 64b6110 (making the solution completely local) if discussion for this is not necessary right now (I could imagine another player screen that would require this sort of fix, namely ReplayPlayer when replaying failing multiplayer scores).

[bdach]

I could imagine another player screen that would require this sort of fix, namely ReplayPlayer when replaying failing multiplayer scores

I think this is out of scope for now because we currently don't even have a way to tell whether a replay is from multiplayer or from solo. So this has been an issue for a long time now, and it is one caused by the fact that the health processor is allowed to fail a replay, while not considering the fact that in some circumstances the conditions for failure may not be the same.

[bdach]

fine by me