Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix taiko legacy input drum animation fade not matching osu!stable #26608

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Fix taiko legacy input drum animation fade not matching osu!stable #26608

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a870f99
ease out input drum animation and add delay before fading out
mouzedrift Jan 18, 2024
cbfc609
apply proposed changes
mouzedrift Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions osu.Game.Rulesets.Taiko/Skinning/Legacy/LegacyInputDrum.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
// See the LICENCE file in the repository root for full licence text.

using System;
using osu.Framework.Allocation;
using osu.Framework.Graphics;
using osu.Framework.Graphics.Containers;
Expand Down Expand Up @@ -153,16 +152,12 @@ public bool OnPressed(KeyBindingPressEvent<TaikoAction> e)

if (target != null)
{
const float alpha_amount = 1;

const float down_time = 80;
const float up_time = 50;

target.Animate(
t => t.FadeTo(Math.Min(target.Alpha + alpha_amount, 1), down_time)
).Then(
t => t.FadeOut(up_time)
);
target
.FadeTo(1, down_time * (1 - target.Alpha), Easing.Out)
.Delay(100).FadeOut(up_time);
}

return false;
Expand Down
Loading