-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getConfig cleanup of consent management #10658
Comments
@RemiSirdata @gsollazzo @darkstarac please take a look |
@patmmccann Hello Patrick. Sorry to bother you, but it's not very clear to us what fix is needed. Have you got some suggestions on this issue ? |
@patmmccann Hello Patrick ? Any hint on this issue ? As asked before we some clarification about the problem. |
@darkstarac consent should not come from a getConfig call. You should only need to access the request object |
|
…1575) * AIDEM Bid Adapter * Added _spec.js * update * Fix Navigator in _spec.js * Removed timeout handler. * Added publisherId as required bidder params * moved publisherId into site publisher object * Added wpar to environment * Added placementId parameter * added unit tests for the wpar environment object * PlacementId is now a required parameter Added optional rateLimit parameter Added publisherId, siteId, placementId in win notice payload Added unit tests * Revert to optional placementId parameter Added missing semicolons * Extended win notice * Added arbitrary ext field to win notice * Moved aidemBidAdapter implementation to comply with ortbConverter * disabled video-specific tests * Fixed getConfig cleanup of consent management (Issue #10658) * Fixed getConfig cleanup of consent management (Issue #10658) * Fixed getConfig cleanup of consent management (Issue #10658) * Fixed getConfig cleanup of consent management (Issue #10658) --------- Co-authored-by: Giovanni Sollazzo <gs@aidem.com> Co-authored-by: darkstar <canazza@wazabit.it> Co-authored-by: AndreaC <67786179+darkstarac@users.noreply.github.com>
* AIDEM Bid Adapter * Added _spec.js * update * Fix Navigator in _spec.js * Removed timeout handler. * Added publisherId as required bidder params * moved publisherId into site publisher object * Added wpar to environment * Added placementId parameter * added unit tests for the wpar environment object * PlacementId is now a required parameter Added optional rateLimit parameter Added publisherId, siteId, placementId in win notice payload Added unit tests * Revert to optional placementId parameter Added missing semicolons * Extended win notice * Added arbitrary ext field to win notice * Moved aidemBidAdapter implementation to comply with ortbConverter * disabled video-specific tests * Fixed getConfig cleanup of consent management (Issue #10658) * Fixed getConfig cleanup of consent management (Issue #10658) * Fixed getConfig cleanup of consent management (Issue #10658) * Fixed getConfig cleanup of consent management (Issue #10658) * Added gvlid param for Europe GDPR compliance --------- Co-authored-by: Giovanni Sollazzo <gs@aidem.com> Co-authored-by: darkstar <canazza@wazabit.it> Co-authored-by: AndreaC <67786179+darkstarac@users.noreply.github.com>
…ebid#11575) * AIDEM Bid Adapter * Added _spec.js * update * Fix Navigator in _spec.js * Removed timeout handler. * Added publisherId as required bidder params * moved publisherId into site publisher object * Added wpar to environment * Added placementId parameter * added unit tests for the wpar environment object * PlacementId is now a required parameter Added optional rateLimit parameter Added publisherId, siteId, placementId in win notice payload Added unit tests * Revert to optional placementId parameter Added missing semicolons * Extended win notice * Added arbitrary ext field to win notice * Moved aidemBidAdapter implementation to comply with ortbConverter * disabled video-specific tests * Fixed getConfig cleanup of consent management (Issue prebid#10658) * Fixed getConfig cleanup of consent management (Issue prebid#10658) * Fixed getConfig cleanup of consent management (Issue prebid#10658) * Fixed getConfig cleanup of consent management (Issue prebid#10658) --------- Co-authored-by: Giovanni Sollazzo <gs@aidem.com> Co-authored-by: darkstar <canazza@wazabit.it> Co-authored-by: AndreaC <67786179+darkstarac@users.noreply.github.com>
…id#11987) * AIDEM Bid Adapter * Added _spec.js * update * Fix Navigator in _spec.js * Removed timeout handler. * Added publisherId as required bidder params * moved publisherId into site publisher object * Added wpar to environment * Added placementId parameter * added unit tests for the wpar environment object * PlacementId is now a required parameter Added optional rateLimit parameter Added publisherId, siteId, placementId in win notice payload Added unit tests * Revert to optional placementId parameter Added missing semicolons * Extended win notice * Added arbitrary ext field to win notice * Moved aidemBidAdapter implementation to comply with ortbConverter * disabled video-specific tests * Fixed getConfig cleanup of consent management (Issue prebid#10658) * Fixed getConfig cleanup of consent management (Issue prebid#10658) * Fixed getConfig cleanup of consent management (Issue prebid#10658) * Fixed getConfig cleanup of consent management (Issue prebid#10658) * Added gvlid param for Europe GDPR compliance --------- Co-authored-by: Giovanni Sollazzo <gs@aidem.com> Co-authored-by: darkstar <canazza@wazabit.it> Co-authored-by: AndreaC <67786179+darkstarac@users.noreply.github.com>
…id#11987) * AIDEM Bid Adapter * Added _spec.js * update * Fix Navigator in _spec.js * Removed timeout handler. * Added publisherId as required bidder params * moved publisherId into site publisher object * Added wpar to environment * Added placementId parameter * added unit tests for the wpar environment object * PlacementId is now a required parameter Added optional rateLimit parameter Added publisherId, siteId, placementId in win notice payload Added unit tests * Revert to optional placementId parameter Added missing semicolons * Extended win notice * Added arbitrary ext field to win notice * Moved aidemBidAdapter implementation to comply with ortbConverter * disabled video-specific tests * Fixed getConfig cleanup of consent management (Issue prebid#10658) * Fixed getConfig cleanup of consent management (Issue prebid#10658) * Fixed getConfig cleanup of consent management (Issue prebid#10658) * Fixed getConfig cleanup of consent management (Issue prebid#10658) * Added gvlid param for Europe GDPR compliance --------- Co-authored-by: Giovanni Sollazzo <gs@aidem.com> Co-authored-by: darkstar <canazza@wazabit.it> Co-authored-by: AndreaC <67786179+darkstarac@users.noreply.github.com>
This is a serious bug in several adapters. Consent management needs to come off the request.
Prebid.js/modules/aidemBidAdapter.js
Line 111 in 56292c4
Prebid.js/modules/apstreamBidAdapter.js
Line 295 in 56292c4
Prebid.js/modules/sirdataRtdProvider.js
Line 85 in 56292c4
Prebid.js/modules/madvertiseBidAdapter.js
Line 56 in 56292c4
The text was updated successfully, but these errors were encountered: