AIDEM Bid Adapter : fixed getConfig cleanup of consent management #11575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added optional rateLimit parameter Added publisherId, siteId, placementId in win notice payload Added unit tests
Added missing semicolons
ChrisHuie
reviewed
May 28, 2024
| let regs = {}; | ||
| const consentManagement = config.getConfig('consentManagement'); | ||
| const euConsentManagement = bidderRequest.gdprConsent; | ||
| const usConsentManagement = bidderRequest.uspConsent; | ||
| const coppa = config.getConfig('coppa'); |
There was a problem hiding this comment.
Better practice to get Coppa from bidderRequest.ortb2.regs.coppa instead of config.
ChrisHuie
changed the title
ChrisHuie
approved these changes
May 28, 2024
DecayConstant
pushed a commit
to mediavine/Prebid.js
that referenced
this pull request
Jul 18, 2024
…ebid#11575) * AIDEM Bid Adapter * Added _spec.js * update * Fix Navigator in _spec.js * Removed timeout handler. * Added publisherId as required bidder params * moved publisherId into site publisher object * Added wpar to environment * Added placementId parameter * added unit tests for the wpar environment object * PlacementId is now a required parameter Added optional rateLimit parameter Added publisherId, siteId, placementId in win notice payload Added unit tests * Revert to optional placementId parameter Added missing semicolons * Extended win notice * Added arbitrary ext field to win notice * Moved aidemBidAdapter implementation to comply with ortbConverter * disabled video-specific tests * Fixed getConfig cleanup of consent management (Issue prebid#10658) * Fixed getConfig cleanup of consent management (Issue prebid#10658) * Fixed getConfig cleanup of consent management (Issue prebid#10658) * Fixed getConfig cleanup of consent management (Issue prebid#10658) --------- Co-authored-by: Giovanni Sollazzo <gs@aidem.com> Co-authored-by: darkstar <canazza@wazabit.it> Co-authored-by: AndreaC <67786179+darkstarac@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Fixed getConfig cleanup of consent management (Issue #10658)