-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Streamlined Buyer and Brand Id's #3115
Comments
Probably should rename |
Does clickUrl always refer to the "landing page" or to the tracking pages in between as well? |
It depends. Some SSPs will use 2 separate URLS and some combine them (daisy chains style). |
Updated split buyer into buyer and network. AppNexus reports both under buyer and most other exchanges report them separately. We want the lowest level of granularity and aggregate it on pub side if needed. |
Updated added IAB Category ID |
@Slind14 |
Looking good. I have added network name for convince. For clarity and order I think it could be of benefit to include the deal and creative id in the meta data, be it by keeping a duplicate in the parent object or depreciating the duplicate with the next breaking version. |
This is a great addition. coming from the publisher side, what are the chances this info can be added into the bids and winning bids scripts ? ie http://prebid.org/dev-docs/troubleshooting-tips.html#see-all-bids-in-the-console and http://prebid.org/dev-docs/troubleshooting-tips.html#see-all-winning-bids-in-the-console The ability to see this would help a great deal in previewing bad creatives and blocking crappy buyers within each of the SSP. |
A small addition to the script and you would be set. Though I highly recommend recording the data so you can track down and block bad ads more easily. |
It would be helpful to distinguish between advertiser and agency, where that information is available. So:
might become:
Would that be feasible? |
Following format specified in prebid#3115
Assuming that bid response has buyer data in format specified in prebid#3115
Following format specified in prebid#3115
Following format specified in prebid#3115
@kelvin-chappell updated it to reflect the additional dimension and added a simple example |
Small update to match what we did for the long form video competitive separation. |
Following format specified in #3115
Following format specified in prebid#3115
Following format specified in prebid#3115
ok, please take a look at https://prebid.org/dev-docs/bidder-adaptor.html and search for |
Looks good. Thank you. |
Also updated the server-side bidder adapter page -- http://lh.prebid.org:8080/prebid-server/developers/add-new-bidder.html#bid-response-metadata |
* add adomain to bid.meta in spotx adapter this puts the adomain key in the right spot, related to #5358 and partially solves #3115 for SpotX * Update spotxBidAdapter.js * Update spotxBidAdapter.js * unit test for adomain on spotx adapter * Update spotxBidAdapter_spec.js * Update spotxBidAdapter_spec.js
* remove these adapters from 4.0 (#5369) Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.SYNAPPNXS.local> * add meta key to interpreted bid response (#5358) * add meta key to interpreted bid response * add more unit tests Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.appnexus.com> Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.SYNAPPNXS.local> * add adomain to bid.meta in spotx adapter (#5401) * add adomain to bid.meta in spotx adapter this puts the adomain key in the right spot, related to #5358 and partially solves #3115 for SpotX * Update spotxBidAdapter.js * Update spotxBidAdapter.js * unit test for adomain on spotx adapter * Update spotxBidAdapter_spec.js * Update spotxBidAdapter_spec.js * adds advertiserDomains meta to the pubmatic adapter (#5402) * adds advertiserDomains meta * Update pubmaticBidAdapter.js * unit test for meta.advertiserDomains to pubmatic * Update pubmaticBidAdapter_spec.js * TCF Purpose 1 and Purpose 2 enforcement for Prebid v4.0 (#5336) * TCF v2.0 enforcement * test/spec/modules/gdprEnforcement_spec.js * add check for gdpr version * add logInfo message * remove comment and store value of PURPOSES in an object * add gvlid check * add unit tests for validateRules function * remove purposeId parameter from validateRules function * add extra tests * make failing unit test case pass * deprecate allowAuctionWithouConsent with tcf 2 workflow * add extra checks for defaults * remove tcf 2 test page * add strict gvlid check * add comments and shorten log messages * shorted log messages * add unit tests for setEnforcementConfig * add gvlid for alias and gvlMapping support * remove gvlid check * add support to add gvlid for aliases Co-authored-by: Jaimin Panchal <email@example.com> * add advertiserDomains meta field to ix adapter (#5404) * add advertiserDomains meta field to ix adapter * Update ixBidAdapter.js * Update ixBidAdapter_spec.js * Update ixBidAdapter_spec.js * add adomain to bid.meta in telaria adapter (#5400) * add adomain to bid.meta in telaria adapter this puts the adomain key in the right spot, related to #5358 and partially solves #3115 for Telaria * Remove digitrust from prebid server js adapter (#5438) * Update prebidServerBidAdapter_spec.js * Update index.js * Interactive advertising bureau digitrust exit (#5429) * Removing DigiTrust ID system core. * Removing test spec for digitrust id. * Removing DigiTrust references from eids test spec. Co-authored-by: Chris Cole <goosemanjack@gmail.com> * Delete serverbidBidAdapter.md (#5477) deprecated in favor of consumable adapter * Set cookie domain in pubcid / userid on main domain, not subdomain (#5500) * update formatting * update formatting * requested changes implemented * add unit test * add test case for missing adomain in ix adapter (#5422) * add test case for missing adomain in ix adapter at request of @ix-prebid-support on #5404 * Update ixBidAdapter_spec.js * Update ixBidAdapter_spec.js * Update ixBidAdapter_spec.js * drop support for userId configs with the `usersync` config object (#5427) * drop support for userId configs with the `usersync` config object, per deprecation notice * changes on drop support (#1) * Update userIdTargeting.md * Update userId.md * Update userId_spec.js * Update britepoolIdSystem.md * Update sharedIdSystem.md Co-authored-by: Patrick McCann <patmmccann@gmail.com> Co-authored-by: sumit sharma <sharmasumit116@gmail.com> Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.SYNAPPNXS.local> Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.appnexus.com> Co-authored-by: Patrick McCann <patmmccann@gmail.com> Co-authored-by: Neelanjan Sen <14229985+Fawke@users.noreply.github.com> Co-authored-by: Jaimin Panchal <email@example.com> Co-authored-by: Neelanjan Sen <neelanjan.sen@gmail.com> Co-authored-by: Chris Cole <goosemanjack@gmail.com> Co-authored-by: Isaac A. Dettman <idettman@rubiconproject.com> Co-authored-by: Scott <smenzer@gmail.com>
@Slind14 - we'd like to propose closing out this issue:
Do you agree this can be closed, working the enforcement in a separate issue? |
Thank you, @bretg Is there any chance that it can be made mandatory with the next breaking release? |
@Slind14 - we're going to make it optional for publishers to configure whether they want to enforce certain fields for certain bidders. Prebid is not in a position to push the entire industry to supply metadata. It's conceivable that such opt-in behavior could become default in the distant future. |
closing and moving to #6453 |
Feature
From a publisher perspective it would be great to get access to the buyer and brand id's. A couple of major exchanges (AppNexus, Rubicon, Index..) are already exposing this data but do not follow a common syntax.
Current Situation:
AppNexus (1.x pbjs bid object)
Rubicon (1.x pbjs bid object)
Index (bid respond, not transmitted to pbjs bid object)
Proposal
Major/Minor Version
Optional streamlined/restful declaration for
buyer
,brand
, landing pagedomain
and additional dynamic information.Breaking Version (2.0)
Network
,Agency
,Buyer
,Brand
andprimaryCatId
become mandatory.Could look like:
Open to discussions
Are there any other variables/meta information which would/could be valuable for you?
The text was updated successfully, but these errors were encountered: