Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebid 4.0 #5534

Merged
merged 24 commits into from
Jul 23, 2020
Merged

Prebid 4.0 #5534

merged 24 commits into from
Jul 23, 2020

Conversation

jsnellbaker
Copy link
Collaborator

Type of change

  • Other

Description of change

Compilation of all the 4.0 changes.

See the list below of the PRs that were merged into this branch:

sumit116 and others added 24 commits June 15, 2020 11:26
Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.SYNAPPNXS.local>
* add meta key to interpreted bid response

* add more unit tests

Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.appnexus.com>
Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.SYNAPPNXS.local>
* add adomain to bid.meta in spotx adapter


this puts the adomain key in the right spot, related to #5358 and partially solves #3115 for SpotX

* Update spotxBidAdapter.js

* Update spotxBidAdapter.js

* unit test for adomain on spotx adapter

* Update spotxBidAdapter_spec.js

* Update spotxBidAdapter_spec.js
* adds advertiserDomains meta

* Update pubmaticBidAdapter.js

* unit test for meta.advertiserDomains to pubmatic

* Update pubmaticBidAdapter_spec.js
* TCF v2.0 enforcement

* test/spec/modules/gdprEnforcement_spec.js

* add check for gdpr version

* add logInfo message

* remove comment and store value of PURPOSES in an object

* add gvlid check

* add unit tests for validateRules function

* remove purposeId parameter from validateRules function

* add extra tests

* make failing unit test case pass

* deprecate allowAuctionWithouConsent with tcf 2 workflow

* add extra checks for defaults

* remove tcf 2 test page

* add strict gvlid check

* add comments and shorten log messages

* shorted log messages

* add unit tests for setEnforcementConfig

* add gvlid for alias and gvlMapping support

* remove gvlid check

* add support to add gvlid for aliases

Co-authored-by: Jaimin Panchal <email@example.com>
* add advertiserDomains meta field to ix adapter

* Update ixBidAdapter.js

* Update ixBidAdapter_spec.js

* Update ixBidAdapter_spec.js
* add adomain to bid.meta in telaria adapter

this puts the adomain key in the right spot, related to #5358 and partially solves #3115 for Telaria
* Update prebidServerBidAdapter_spec.js

* Update index.js
* Removing DigiTrust ID system core.

* Removing test spec for digitrust id.

* Removing DigiTrust references from eids test spec.

Co-authored-by: Chris Cole <goosemanjack@gmail.com>
deprecated in favor of consumable adapter
…5500)

* update formatting

* update formatting

* requested changes implemented

* add unit test
* add test case for missing adomain in ix adapter

at request of @ix-prebid-support on #5404

* Update ixBidAdapter_spec.js

* Update ixBidAdapter_spec.js

* Update ixBidAdapter_spec.js
)

* drop support for userId configs with the `usersync` config object, per deprecation notice

* changes on drop support (#1)

* Update userIdTargeting.md

* Update userId.md

* Update userId_spec.js

* Update britepoolIdSystem.md

* Update sharedIdSystem.md

Co-authored-by: Patrick McCann <patmmccann@gmail.com>
@jsnellbaker jsnellbaker requested a review from Fawke July 23, 2020 12:26
@lgtm-com
Copy link

lgtm-com bot commented Jul 23, 2020

This pull request fixes 1 alert when merging 02cdf47 into bf5c7c7 - view on LGTM.com

fixed alerts:

  • 1 for Useless conditional

@jsnellbaker jsnellbaker merged commit 61ba086 into master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants