Move special Bid adapter handling from RTD modules into those adapters

[patmmccann]

RTD adapters, particularly those that pre-date standardization of the user.data or site.content.data objects, often have special handling for various bid adapters that don't yet accept standard first party data objects. Discussion in the taxonomy and js committees has suggests this special handling should be moved into those respective bid adapters so that the data controller module can apply.

List of special handlings subject to research.

[ChrisHuie]

List of current RTD modules that have bidder specific logic.

1plusXRTD - Appnexus specific handling
Airgrid - Appnexus specific handling
Captify - Appnexus specific handling

Weboraama - Appnexus, Rubicon, Pubmatic, and SmartAdServer specific logic

Sirdata - CurationID and specific logic for several specific bidders including Xandr, Pubmatic, OpenX, Smart, Rubicon,
IX, Proxistore, Criteo, Triplelift, Avocet, Smaato, and Yahoossp

[patmmccann]

from a conversation with the permutive team on #9555

There are no concerns with an rtd adapter passing information that is private to a bidder, but the js shouldn't need to name bidders to do so. It could take config that looks roughly like this to achieve it:

permutiveRTD: { privateSegments: { what: '_prubicon', who: 'rubicon' where: 'user.ext.data._prubicon'} { who: 'appnexus', what: '_pappnexus', where: 'site.keywords.ext.appnexus' }}

[ydennisy]

@patmmccann I stumbled across this accidentally!

I am about to make some changes to our adapter - is there anything I can do for this yet, I assume from your message above this is a little while out.

[patmmccann]

This issue is approved for prebid 8 enforcement

[patmmccann]

Adding some detail here:

AppNexus picks up

Prebid.js/modules/appnexusBidAdapter.js

Line 269 in 38cf634

let anAuctionKeywords = deepClone(config.getConfig('appnexusAuctionKeywords')) || {};

and three adapters write to that location

Prebid.js/modules/airgridRtdProvider.js

Line 109 in 38cf634

config.setConfig({

Prebid.js/modules/1plusXRtdProvider.js

Line 220 in 38cf634

config.setConfig({

Prebid.js/modules/captifyRtdProvider.js

Line 30 in 38cf634

config.setConfig({

RTD adapters are not supposed to do setConfig with Prebid 7 was my recollection, but perhaps that is in error. My proposal is that all three of these adapters are modified to convert their segments into keywords for the configuration-specified adapter's request object in the format key=value where the key also comes from configuration and defaults to respectively:

airgrid: 'perid' as matching

Prebid.js/modules/airgridRtdProvider.js

Line 111 in 38cf634

perid: audiences,

captify: 'captify_segments' as matching

Prebid.js/modules/captifyRtdProvider.js

Line 32 in 38cf634

'captify_segments': segments,

1plusX: '1plusX' as matching

Prebid.js/modules/1plusXRtdProvider.js

Line 222 in 38cf634

'1plusX': audiences,

In this manner none of these rtd adapters will have bidder specific code and publishers will have to specify the bidders that get their ortb2 object keywords appended in the rtd module config.

Additionally, the appnexus adapter should maintain line

Prebid.js/modules/appnexusBidAdapter.js

Line 269 in 38cf634

let anAuctionKeywords = deepClone(config.getConfig('appnexusAuctionKeywords')) || {};

in case publishers are setting this manually now.

However, the entry point into the appnexus adapter for rtd keywords will now be

Prebid.js/modules/appnexusBidAdapter.js

Line 267 in 38cf634

let ortb2KeywordsObjList = grabOrtb2Keywords(ortb2).map(keyStr => convertStringToKeywordsObj(keyStr));

What do we think @dgirardi @jsnellbaker

This seems to avoid the more heavyhanded #9952 type PR

[patmmccann]

In the case of Weborama, bidder specific handling is deeply embedded into the adapter and difficult to remove, with many adapters having data written directly to params, eg

Prebid.js/modules/weboramaRtdProvider.js

Line 744 in 38cf634

#handlePubmaticBid(bid, profile) {

fyi @peczenyj

Potentially the same with Sirdata, eg

Prebid.js/modules/sirdataRtdProvider.js

Line 380 in 38cf634

case 'smart':

Prebid.js/modules/sirdataRtdProvider.js

Line 396 in 38cf634

case 'ix':

I am not sure if it is better to delete these handlings or just drop the module from 8 until we can contact the sirdata team @nouchy @RemiSirdata

in the case of permutive, it appears #9639 might be the last piece of the puzzle for them

[dgirardi]

In this manner none of these rtd adapters will have bidder specific code and publishers will have to specify the bidders that get their ortb2 object keywords appended in the rtd module config.

I believe those keywords would be meaningless to everyone except appnexus. It's still an improvement since at least aliases and clones could work, but it's still special handling; I'd prefer if the authors tried to use user.data (and kudos to airgrid for attempting it).

[patmmccann]

#9628 rather for permutive

[nouchy]

In the case of Weborama, bidder specific handling is deeply embedded into the adapter and difficult to remove, with many adapters having data written directly to params, eg

Prebid.js/modules/weboramaRtdProvider.js

Line 744 in 38cf634

#handlePubmaticBid(bid, profile) {

fyi @peczenyj

Potentially the same with Sirdata, eg

Prebid.js/modules/sirdataRtdProvider.js

Line 380 in 38cf634

case 'smart':

Prebid.js/modules/sirdataRtdProvider.js

Line 396 in 38cf634

case 'ix':

I am not sure if it is better to delete these handlings or just drop the module from 8 until we can contact the sirdata team @nouchy @RemiSirdata

in the case of permutive, it appears #9639 might be the last piece of the puzzle for them

Hi... Now bidders like Xandr (Appnexus) also work we ortb2. We'll ugrade our RTD submodule ASAP, and remove non-standard handlers. Thanks !

[peczenyj]

Hey @patmmccann and otherw

we (as Weborama) don’t mind in remove the specific code to Appnexus and other SSPs if they start to support standard user.data or site.content.data objects (or deleted by not support it)

[patmmccann]

@nouchy excellent!

[nouchy]

@nouchy excellent!

:) Done... Here is the PR : #9970

Thanks Patrick

[patmmccann]

@peczenyj curious for an update, thanks!

[peczenyj]

Working on it Em ter., 23/05/2023 às 20:15, Patrick McCann ***@***.***> escreveu:

@peczenyj <https://github.com/peczenyj> curious for an update, thanks! — Reply to this email directly, view it on GitHub <#8596 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAOQLXOM2THWBGT7RHU5ZDXHT5ERANCNFSM5ZP6DSEQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Tiago B. Peczenyj http://about.me/peczenyj

[peczenyj]

Someone can check? I am still not sure Appnexus

#10005