Adagio Rtd Provider: initial release #11509
Conversation
osazos
force-pushed
the
adagio-feature/adagioRtdProvider
branch
from
b32357a
to
70bfded
Compare
| }, | ||
|
|
||
| /** | ||
| * Ensure that the bidder is Adagio. |
There was a problem hiding this comment.
RTD modules cannot favor a particular hardcoded bidder. They can favor bidders if the list is taken from publisher configuration; but they cannot 'compute features only for the adagio bidder'
There was a problem hiding this comment.
Ok, I'll do the changes, it was already planed anyway.
Beside this required change, is there anything that is not compliant? Thx
There was a problem hiding this comment.
no other than this looks good!
osazos
force-pushed
the
adagio-feature/adagioRtdProvider
branch
from
68e081d
to
d8bed88
Compare
|
@patmmccann the changes have been done in d8bed88. Here the summary:
|
osazos
force-pushed
the
adagio-feature/adagioRtdProvider
branch
from
d8bed88
to
8b3d8a2
Compare
| // `placement` is expected in FPD `adUnits[].ortb2Imp.ext.data` object. (Please note that this `placement` is not related to the oRTB video property.) | ||
| // Btw, we have to ensure compatibility with publishers that use the "legacy" adagio params at the adUnit.params level. | ||
| const adagioBid = adUnit.bids.find(bid => _internal.isAdagioBidder(bid.bidder)); | ||
| if (adagioBid) { |
There was a problem hiding this comment.
hI @osazos ! I noticed a new commit, and also this special handling for the adagio bidder in this block remains. in #8596 for Prebid 8, all special handling of rtd information was moved from the rtd module into the bid module. If your bidder needs to look at the injected rtd info differently than a typical bidder, why not put that in your bidder js?
There was a problem hiding this comment.
Hi @patmmccann,
Let me know if I misunderstand your comment, because the fallback is to handle the opposite: we set for "all" what was set for the adagio adapter.
The case is, when a client has its ad-units already configured at the adUnits[].adagio.params level and switch to the rtd Provider, he must move some of these params at the FPD level. In the real life, our clients won't have the flexibility to easily do the switch. Applying this fallback allow us to progressively onboard them.
* AdagioRtdProvider: add Adagio Rtd Provider * AdagioRtdProvider: missing callback() call * AdagioRtdProvider: set signals for all
Type of change
Description of change
New Rtd Provider for Adagio. This is the following of #11485.
Context for reviewers:
We computes and collects data required to leverage Adagio viewability and attention prediction engine.
To do so we need an external script. Historically this script was loaded from the adagioBidAdapter this was before the RTD modules were implemented. This behavior becomes not accepted with #10653.
This provider essentially mirrors what we did in our bidAdapter, minus the "cache" system that previously required us to use
Function()and the encryption verification.In Prebid.js 9, this module will be mandatory to work with Adagio and our bidder adapter will be "cleaned" to remove duplicated code. But, rather than waiting for v.9 to be released, some slight modifications have been done to our bidAdapter to ensure compatibility and to streamline the transition for our clients. See #11485.
Contact email of the maintainer: dev@adagio.io, osazos@adagio.io
Other information
@patmmccann, please find here the Rtd Provider for Adagio. The next step is to clean the Adagio Bid Adapter and open PR on the 9.0 branch.