Quantcast adaptor #1063

ShreeniwasIyer · 2017-03-22T10:43:16Z

We are implementing a new adaptor for Quantcast with a code name qcx for the bidderCode.

Type of change

Description of change

test parameters for validating bids

{
  bidder: 'quantcast',
  params: {
    publisherId: 'LCOf845vzU',
    battr : [1,2]
  }
}

contact email of the adapter’s maintainer
[Quantcast Inventory Supply Team] inventoryteam@quantcast.com

Other information

…_adaptor

…cx_adaptor

… Prebid.js

…cx_adaptor

…in the requests object

aneuway2 · 2017-03-22T21:10:09Z

Hey @ShreeniwasIyer are publisherId and battr both required parameters for your adaptor? Might be good to submit a PR to have this documented :-)

https://github.com/prebid/prebid.github.io/tree/master/dev-docs/bidders

ShreeniwasIyer · 2017-03-24T08:35:07Z

Thanks @aneuway2 for pointing out. Done now through prebid/prebid.github.io#204

ShreeniwasIyer · 2017-04-03T08:44:14Z

Hi @aneuway2 , @mkendall07 - does this need any more inputs before review? I see that PRs submitted after this one have already been reviewed - so was wondering if I missed something..

mkendall07 · 2017-04-05T00:42:52Z

@ShreeniwasIyer
We will review this for the next release. Thanks

jaiminpanchal27

@ShreeniwasIyer Please check comments

Test parameters has bidder: 'qcx', it should be bidder:'quantcast' as defined in adapters.json

Also i am not able get bids back while testing from localhost due to CORS.

jaiminpanchal27 · 2017-04-19T15:01:26Z

src/adapters/quantcast.js

+
+  const DEFAULT_BID_FLOOR = 0.0000000001;
+  // The following 2 constants are adopted from bidfactory.js codes
+  const BID_STATUS_CODE_AVAILABLE = 1;


Use STATUS.GOOD and STATUS.NO_BID defined in constants.json

Done. Thanks. @jaiminpanchal27

jaiminpanchal27 · 2017-04-19T15:01:49Z

src/adapters/quantcast.js

+    if(utils.isEmpty(responseText)) {
+      return;
+    }
+    let response = JSON.parse(responseText);


wrap this in try catch

jaiminpanchal27 · 2017-04-19T15:03:57Z

src/adapters/quantcast.js

+    publisherId = '' + bids[0].params.publisherId;
+    utils._each(bids, function(bid) {
+      // make sure the "sizes" are an array of arrays
+      if (!(bid.sizes[0] instanceof Array)) {


DFP allows sizes to be array and array of arrays. Support both.
parseSizesInput function https://github.com/prebid/Prebid.js/blob/master/src/utils.js#L117 will help

jaiminpanchal27 · 2017-04-19T15:06:02Z

src/adapters/quantcast.js

+  let returnEmptyBid = function() {
+      var bidsRequested = $$PREBID_GLOBAL$$._bidsRequested.find(bidSet => bidSet.bidderCode === BIDDER_CODE).bids;
+      if (bidsRequested.length > 0) {
+        let bid = bidfactory.createBid(BID_STATUS_CODE_EMPTY);


Pass bidRequest as second param

jaiminpanchal27 · 2017-04-19T15:06:47Z

src/adapters/quantcast.js

+  let bidRequests = {};
+
+  let returnEmptyBid = function() {
+      var bidsRequested = $$PREBID_GLOBAL$$._bidsRequested.find(bidSet => bidSet.bidderCode === BIDDER_CODE).bids;


Use getBidRequest https://github.com/prebid/Prebid.js/blob/master/src/utils.js#L518

jaiminpanchal27 · 2017-04-19T15:08:45Z

test/spec/adapters/quantcast_spec.js

+
+  beforeEach(() => {
+    bidsRequestedOriginal = pbjs._bidsRequested;
+    pbjs._bidsRequested = [];


Use $$PREBID_GLOBAL$$ at all places in this file

…o match to null

ShreeniwasIyer · 2017-04-20T08:12:21Z

@jaiminpanchal27 I fixed the code as per the comments above. We are also currently pushing an change to our domain handling to allow for testing from localhost on certain test cases, this one inclusive. I believe it should be done in the next 3 hours or so.

ShreeniwasIyer · 2017-04-21T10:19:58Z

@jaiminpanchal27 All changes are done both in JS and server side and it seems we are good to go. Please review. (The last build is working from the PR perspective, but failing on some other test, which seems to pass sometimes and fail at other times. Please re-invoke the tests and I am confident they will pass.)

jaiminpanchal27 · 2017-04-21T13:50:25Z

@ShreeniwasIyer I now see response but its not a valid bid. Here is the response i get.
{"bidderCode":"qcx","bids":[{"height":250,"placementCode":"div-gpt-ad-1438287399331-0","statusCode":0,"width":300}],"requestId":"280f6c64a34097"}

…o qcx_adaptor

ShreeniwasIyer · 2017-04-28T23:55:31Z

Hi @jaiminpanchal27 , thanks for your review comments. We have fixed a few issues we noticed along the way. Now our bidder is definitely responding with the bids and would do so, so long as you are testing this on localhost and you are doing this from an US IP.

Please note that we have updated the publisherId in the PR - so please use the revised one while testing.

Can you please review and let us know?

jaiminpanchal27 · 2017-05-01T14:43:14Z

@ShreeniwasIyer I still see the same CORS error. I am testing from US ip.
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at http://global.qc.rtb.quantserve.com:8080/qchb. (Reason: expected ‘true’ in CORS header ‘Access-Control-Allow-Credentials’). (unknown)

I am testing using this example page, https://jsfiddle.net/L618t79a/ Update prebid path before testing at your end.

Ajax request to your endpoint
curl 'http://global.qc.rtb.quantserve.com:8080/qchb' -H 'Cookie: mc=58f61b01-efd3a-4c41c-d26e7; d=EAUB4AEB4heBkwo9-Tk8LivvgwqLLx7NTB2MQsMAAAEPhSrqMLkgIgkgAAkQAAC-IADcMJiiKPURC6QAAAMNmGAQ6Vgri6KSuKwgDB7eEZ9Cn5LxnJVK1YLugfHI0YHeknji4f_bEO2i8f_ygpjH8ZzcIYsg' -H 'Origin: http://localhost:9999' -H 'Accept-Encoding: gzip, deflate' -H 'Accept-Language: en-US,en;q=0.8,gu;q=0.6' -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.81 Safari/537.36' -H 'Content-Type: text/plain' -H 'Accept: */*' -H 'Cache-Control: max-age=0' -H 'Referer: http://localhost:9999/integrationExamples/gpt/adapter/qcast.html' -H 'Connection: keep-alive' --data-binary '{"publisherId":"LCOf845vzU","requestId":"2c83a976870a59","bidId":"2c83a976870a59","site":{"page":"http://localhost:9999/integrationExamples/gpt/adapter/qcast.html","referrer":"http://localhost:9999/integrationExamples/gpt/adapter/qcast.html","domain":"localhost"},"imp":[{"banner":{"battr":[1,2],"sizes":[{"width":728,"height":90},{"width":300,"height":250},{"width":300,"height":600}]},"placementCode":"div-gpt-ad-1438287399331-0","bidFloor":1e-10}]}' --compressed

Let me know if i am doing something wrong here.
You can also reach out to me on jpanchal@appnexus.com

ShreeniwasIyer · 2017-05-02T17:13:45Z

Thanks @jaiminpanchal27 for the review. Would you be merging it into the master when ready for next release? Do I need to do anything else?

jaiminpanchal27 · 2017-05-02T17:16:18Z

@ShreeniwasIyer It looks good to me. No you don't need to do anything else from your side.
As per our process, any of the contributor from core team will check and give second LGTM and merge.

mkendall07 · 2017-05-02T18:20:48Z

src/adapters/quantcast.js

+    } catch(e) {
+      // Malformed JSON
+      utils.logError("Malformed JSON received from server - can't do anything here");
+      return;


Should really try to add a error bid here if possible

@mkendall07 I tried to, but at that point in code we don't have the placement code for which the empty text response came and hence returning an error bid isn't possible..

jaiminpanchal27 · 2017-05-02T20:41:41Z

This is merged into master. Please submit a PR to the docs repo to add a file for your adapter to the bidders directory so your adapter's params will appear on the bidders page. Thank you for contributing

…built * 'master' of https://github.com/prebid/Prebid.js: (21 commits) add lodash as dependency (prebid#1174) fix size mapping for s2s (prebid#1175) Improve footer styling (prebid#1171) Bugfix: internal bids requested overwritten (prebid#1173) pre-release version bump Prebid 0.23.0 Release Yieldbot adapter - multiple requestBids per pageview (prebid#1146) Widespace adapter validate size fix (prebid#1140) Audience Network: bid when at least one valid slot size (prebid#1148) Quantcast adaptor (prebid#1063) AOL Adapter - ONE Mobile endpoint implemented. (prebid#1115) Prebid Server to Server (prebid#1165) Pubgears Header Bidding Adapter (prebid#953) remove old adloader#trackPixel (prebid#1159) added audit beacon to detect misuse of this bidder. Detects auctions… (prebid#1134) Bidfluence CDN endpoint URL update (prebid#1163) AdSupply adapter (prebid#1162) Sonobi Adapter - Enable size overrides (prebid#1141) Added an editorconfig file to match jshint and jssrc files. (prebid#1147) force cpm to be a number (prebid#1161) ...

…21.0 to aolgithub-master * commit '4d573b42c5fbbabf23fed48fa042b75a72dd16b2': (31 commits) Added prebidServer in aolPartnersIds.json. Added adapters in aolPartnersIds.json. Added changelog entry. Prebid 0.23.1 Release Add trafficSourceCode + test (prebid#1184) Clear cookie sync to prevent multiple calls (prebid#1181) change s2s adapter to filter out units with empty sizes array (prebid#1179) Sharethrough: Change to using a closure for the callback from ajax to preserve bidObj (prebid#1108) check array length when mapping sizes (prebid#1180) Bugfix/encoding url (prebid#1178) add lodash as dependency (prebid#1174) fix size mapping for s2s (prebid#1175) Improve footer styling (prebid#1171) Bugfix: internal bids requested overwritten (prebid#1173) pre-release version bump Prebid 0.23.0 Release Yieldbot adapter - multiple requestBids per pageview (prebid#1146) Widespace adapter validate size fix (prebid#1140) Audience Network: bid when at least one valid slot size (prebid#1148) Quantcast adaptor (prebid#1063) ...

ShreeniwasIyer added 20 commits March 8, 2017 18:17

Initial code

2fca458

First cut of the adapter

8b47e0f

Merge branch 'master' of https://github.com/prebid/Prebid.js into qcx…

470e5c1

…_adaptor

Renaming for consistency

5292542

Indendation and syntax changes

456ed26

request processing has been completed

58b294a

Merge branch 'master' of github.corp.qc:qc/INVENTORY-prebid.js into q…

bb6a711

…cx_adaptor

Further testing

584d8f0

Merge branch 'master' of github.corp.qc:qc/INVENTORY-prebid.js into q…

6459e39

…cx_adaptor

Switched to using Placement Code

70edd91

Renamed the fields of request and response to be more consistent with…

881fb06

… Prebid.js

Merge branch 'master' of github.corp.qc:qc/INVENTORY-prebid.js into q…

b79c82b

…cx_adaptor

Added Unit tests

2c5f386

Merging with Public master

3534d42

Changed the URL

1ea9bce

Fixed nit:spacing issues

d05db9e

Added fix for the case when request is not found for whatever reason …

1a0e9a6

…in the requests object

nit being resolved

a7f11c9

Addressing comments

4c2c8c7

Fixed the indentation as per jshint errors on travis-ci build

22b6741

ShreeniwasIyer added 2 commits March 24, 2017 14:10

Merge branch 'master' of github.com:prebid/Prebid.js into qcx_adaptor

35e6574

Replacing qcx with Quantcast and changing URL

6885f2a

ShreeniwasIyer changed the title ~~Qcx adaptor~~ Quantcast adaptor Mar 24, 2017

ShreeniwasIyer mentioned this pull request Mar 24, 2017

Adding Quantcast as a bidder - complimenting the Prebid.js adaptor prebid/prebid.github.io#204

Merged

jaiminpanchal27 self-assigned this Apr 10, 2017

jaiminpanchal27 requested changes Apr 19, 2017

View reviewed changes

ShreeniwasIyer added 4 commits April 20, 2017 15:32

Replacing array wrapping with parseSizesInput usage to make it cleaner

0d92aed

Fixed the error, not caught in gulp test

8442e44

No need to compare to undefined since as per new code, we only need t…

a36db04

…o match to null

Fixed the warning

2b28a4e

ShreeniwasIyer and others added 2 commits April 21, 2017 18:00

integration testing and adding quantcast to the demo html page

c8a401c

Merge branch 'master' into qcx_adaptor

ce6118d

ShreeniwasIyer added 5 commits April 26, 2017 19:23

Converting sizes into an object and removing the single size object

35f328a

Merge branch 'qcx_adaptor' of github.com:ShreeniwasIyer/Prebid.js int…

64bbbdc

…o qcx_adaptor

Added withCredentials variable to AJAX calls

f8f0baa

using placement code as the key

fae67ac

Adding the bidder code and request id to responseBid

8e3a19a

jaiminpanchal27 approved these changes May 2, 2017

View reviewed changes

jaiminpanchal27 added LGTM and removed needs update labels May 2, 2017

protonate requested a review from matthewlane May 2, 2017 18:19

protonate added this to the Prebid 0.23.0 milestone May 2, 2017

mkendall07 reviewed May 2, 2017

View reviewed changes

mkendall07 approved these changes May 2, 2017

View reviewed changes

protonate merged commit 90e67f0 into prebid:master May 2, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Quantcast adaptor #1063

Quantcast adaptor #1063

ShreeniwasIyer commented Mar 22, 2017 •

edited

Loading

aneuway2 commented Mar 22, 2017

ShreeniwasIyer commented Mar 24, 2017

ShreeniwasIyer commented Apr 3, 2017

mkendall07 commented Apr 5, 2017

jaiminpanchal27 left a comment

jaiminpanchal27 Apr 19, 2017

ShreeniwasIyer Apr 20, 2017

jaiminpanchal27 Apr 19, 2017

jaiminpanchal27 Apr 19, 2017

jaiminpanchal27 Apr 19, 2017

jaiminpanchal27 Apr 19, 2017

jaiminpanchal27 Apr 19, 2017

ShreeniwasIyer commented Apr 20, 2017

ShreeniwasIyer commented Apr 21, 2017

jaiminpanchal27 commented Apr 21, 2017

ShreeniwasIyer commented Apr 28, 2017 •

edited

Loading

jaiminpanchal27 commented May 1, 2017

ShreeniwasIyer commented May 2, 2017

jaiminpanchal27 commented May 2, 2017 •

edited

Loading

mkendall07 May 2, 2017

ShreeniwasIyer May 2, 2017

jaiminpanchal27 commented May 2, 2017

Quantcast adaptor #1063

Quantcast adaptor #1063

Conversation

ShreeniwasIyer commented Mar 22, 2017 • edited Loading

Type of change

Description of change

Other information

aneuway2 commented Mar 22, 2017

ShreeniwasIyer commented Mar 24, 2017

ShreeniwasIyer commented Apr 3, 2017

mkendall07 commented Apr 5, 2017

jaiminpanchal27 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ShreeniwasIyer commented Apr 20, 2017

ShreeniwasIyer commented Apr 21, 2017

jaiminpanchal27 commented Apr 21, 2017

ShreeniwasIyer commented Apr 28, 2017 • edited Loading

jaiminpanchal27 commented May 1, 2017

ShreeniwasIyer commented May 2, 2017

jaiminpanchal27 commented May 2, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jaiminpanchal27 commented May 2, 2017

ShreeniwasIyer commented Mar 22, 2017 •

edited

Loading

ShreeniwasIyer commented Apr 28, 2017 •

edited

Loading

jaiminpanchal27 commented May 2, 2017 •

edited

Loading