Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prebid Server to Server #1165

Merged
merged 31 commits into from
May 2, 2017
Merged

Prebid Server to Server #1165

merged 31 commits into from
May 2, 2017

Conversation

jaiminpanchal27
Copy link
Collaborator

@jaiminpanchal27 jaiminpanchal27 commented Apr 28, 2017 •
edited by protonate
Loading

Type of change

  • Feature

Description of change

Allows a publisher to send requests to Prebid Server. To enable, use the following API:

pbjs.setS2SConfig({
   accountId : '1',                     //string:required: account ID obtained in step 1 
   enabled : true,                      //boolean:required: enables s2s - default false
   bidders : ['appnexus','pubmatic'],   //array[string]:required: of bidder codes to enable S2S. Note these must have been including in the Prebid.js build from Step 2. 
   timeout : 1000,                      //number:optional timeout for bidders called via the S2S endpoint. default value is 1000 
   adapter : 'prebidServer',                     //string:optional: Adapter code for S2S code. Defaults to 'prebidServer'
   endpoint : 'http://prebid.adnxs.com' //string:optional: will override default endpoint for prebid server. 
});

Other information

@prebid/core for review
Will add some more unit tests soon.

mkendall07 and others added 22 commits March 28, 2017 14:25
@mkendall07
s2s
fccc7b4
@mkendall07
-update
1bcd3cb
@mkendall07
Revert "-update"
653e040 
This reverts commit 1bcd3cb.
@mkendall07
fixed heigth and width
a856346
@mkendall07
updates
72f5b96
@jaiminpanchal27
Prebid server to server
d901841
@mkendall07
Add cookie sync
82c4337
@jaiminpanchal27
Adding bid to bidsRequested
acde99f
@jaiminpanchal27
Merge branch 'experiment/s2s' of github.com:prebid/Prebid.js into exp…
395b09c 
…eriment/s2s
@jaiminpanchal27
Updated bid_id code returned by server
7db4c80
@mkendall07
update per URL coming back in response
4ce87a1
@mkendall07
Merge branch 'experiment/s2s' of https://github.com/prebid/Prebid.js …
fe78d5b 
…into experiment/s2s
@jaiminpanchal27
saving bid requests in adapter
c0db945
@jaiminpanchal27
Merge branch 'experiment/s2s' of github.com:prebid/Prebid.js into exp…
b399c41 
…eriment/s2s
@jaiminpanchal27
Unit tests for s2s adapter
f3faf41
@jaiminpanchal27
Handling no bid response and cookie sync url updates
87fd4c2
@jaiminpanchal27
Code refactor, added new param to s2sConfig public api
fc019b9
@jaiminpanchal27
Merge branch 'master' of github.com:prebid/Prebid.js into experiment/s2s
dc436d7 
# Conflicts:
#	src/prebid.js
#	src/utils.js
@jaiminpanchal27
Added missing functions back and updated endpoint
bfac3d1
@jaiminpanchal27
Added required param check and unit tests
93adadb
@jaiminpanchal27
top url fix
34d89ec
@jaiminpanchal27
Remove clutter and bug fix
b485afb
@protonate protonate self-requested a review April 28, 2017 22:08
@protonate protonate removed their assignment May 1, 2017
protonate
protonate approved these changes May 2, 2017
View reviewed changes
Copy link
Collaborator

@protonate protonate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor notes, I think if adapter name can be updated to prebidServer we can merge, and address other items later.

integrationExamples/gpt/s2s.html Outdated
enabled : true, //default value set to false
bidders : ['appnexus'],
timeout : 1000, //default value is 1000
adapter : 's2s', //if we have any other s2s adapter, default value is s2s
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update to 'prebidServer'

src/adaptermanager.js
@@ -31,7 +33,7 @@ function getBids({bidderCode, requestId, bidderRequestId, adUnits}) {
mediaType: adUnit.mediaType,
transactionId : adUnit.transactionId,
sizes: sizes,
bidId: utils.getUniqueIdentifierStr(),
bidId: bid.bid_id || utils.getUniqueIdentifierStr(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should make this more descriptive e.g. s2s_id?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually just that, a bid_id

src/adapters/prebidServer.js
import { queueSync, persist } from 'src/cookie.js';

const TYPE = 's2s';
const cookiePersistMessage = `Your browser may be blocking 3rd party cookies. By clicking on this page you allow Prebid Server and other advertising partners to place cookies to help us advertise. You can opt out of their cookies <a href="https://www.appnexus.com/en/company/platform-privacy-policy#choices" target="_blank">here</a>.`;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should look at how to make this configurable by pubs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's part of using prebid server for now. So opt out would be don't use prebid server.

@protonate protonate added this to the Prebid 0.23.0 milestone May 2, 2017
@protonate protonate merged commit 4470c08 into master May 2, 2017
outoftime pushed a commit to Genius/Prebid.js that referenced this pull request May 4, 2017
Merge branch 'master' of https://github.com/prebid/Prebid.js into pre…
482c0ed 
…built

* 'master' of https://github.com/prebid/Prebid.js: (21 commits)
  add lodash as dependency (prebid#1174)
  fix size mapping for s2s (prebid#1175)
  Improve footer styling (prebid#1171)
  Bugfix: internal bids requested overwritten (prebid#1173)
  pre-release version bump
  Prebid 0.23.0 Release
  Yieldbot adapter - multiple requestBids per pageview (prebid#1146)
  Widespace adapter validate size fix (prebid#1140)
  Audience Network: bid when at least one valid slot size (prebid#1148)
  Quantcast adaptor (prebid#1063)
  AOL Adapter - ONE Mobile endpoint implemented. (prebid#1115)
  Prebid Server to Server (prebid#1165)
  Pubgears Header Bidding Adapter (prebid#953)
  remove old adloader#trackPixel (prebid#1159)
  added audit beacon to detect misuse of this bidder.  Detects auctions… (prebid#1134)
  Bidfluence CDN endpoint URL update (prebid#1163)
  AdSupply adapter (prebid#1162)
  Sonobi Adapter - Enable size overrides (prebid#1141)
  Added an editorconfig file to match jshint and jssrc files. (prebid#1147)
  force cpm to be a number (prebid#1161)
  ...
@mkendall07 mkendall07 deleted the experiment/s2s branch May 19, 2017 00:42
@klawil klawil mentioned this pull request Nov 7, 2017
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkendall07 mkendall07 mkendall07 left review comments

@protonate protonate protonate approved these changes

@matthewlane matthewlane Awaiting requested review from matthewlane

Assignees

@jaiminpanchal27 jaiminpanchal27

Labels
None yet
Projects
None yet
Milestone
Prebid 0.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jaiminpanchal27 @mkendall07 @protonate