Update gambid aliases #3410
Update gambid aliases #3410
Conversation
Sync upstream
This is a minor branding change to highlight the Gamoshi brand name. The biddercode "gambid" is still retained in the adapter aliases array.
modules/gamoshiBidAdapter.js
Outdated
| const rtbEndpoint = `${baseEndpoint}/r/${params.supplyPartnerId}/bidr?rformat=open_rtb&reqformat=rtb_json&bidder=prebid` + (params.query ? '&' + params.query : ''); | ||
| let url = config.getConfig('pageUrl'); |
There was a problem hiding this comment.
config.getConfig('pageUrl') will never be used because if it exists it will trigger the else block below where it's reset to utils.getTopWindowUrl()
maybe:
let url = config.getConfig('pageUrl') || bidderRequest && bidderRequest.refererInfo && bidderRequest.refererInfo.referer || utils.getTopWindowUrl();
There was a problem hiding this comment.
which means there must not be a test verifying the expected behavior.
There was a problem hiding this comment.
@sa1omon I don't see any new commits.
There was a problem hiding this comment.
@harpere please check it again now.
There was a problem hiding this comment.
@sa1omon - Sorry, logically that should work, but lint doesn't like it. CircleCI error: Unexpected mix of '||' and '&&' no-mixed-operators.
I figured you'd want to document all 3 bidder codes |
@harpere I have created this pull request: Add cleanmedia bidder code #1078, in the prebid.github.io repository to update the docs. thanks |
modules/gamoshiBidAdapter.js
Outdated
| const rtbEndpoint = `${baseEndpoint}/r/${params.supplyPartnerId}/bidr?rformat=open_rtb&reqformat=rtb_json&bidder=prebid` + (params.query ? '&' + params.query : ''); | ||
| let url = config.getConfig('pageUrl') || bidderRequest && | ||
| bidderRequest.refererInfo && bidderRequest.refererInfo.referer || | ||
| utils.getTopWindowUrl(); |
There was a problem hiding this comment.
logically this works, but apparently lint doesn't like it. CircleCI error: Unexpected mix of '||' and '&&' no-mixed-operators.
There was a problem hiding this comment.
maybe
let referer = bidderRequest && bidderRequest.refererInfo && bidderRequest.refererInfo.referer
let url = config.getConfig('pageUrl') || referer || utils.getTopWindowUrl();
There was a problem hiding this comment.
@harpere I have uploaded a fix. thanks
|
Docs PR prebid/prebid.github.io#1078 |
@bretg Did you see my answer for your question on that PR? thanks. |
* Update the Gamoshi Gambid adapter to simply the Gamoshi adapter This is a minor branding change to highlight the Gamoshi brand name. The biddercode "gambid" is still retained in the adapter aliases array. * update whitelabel * Add test that checks support for outstream renderers * Update testing and page ref * Modify bidder's url resolving * Fix lint issue with bidder's url resolving
* Update the Gamoshi Gambid adapter to simply the Gamoshi adapter This is a minor branding change to highlight the Gamoshi brand name. The biddercode "gambid" is still retained in the adapter aliases array. * update whitelabel * Add test that checks support for outstream renderers * Update testing and page ref * Modify bidder's url resolving * Fix lint issue with bidder's url resolving
* Update the Gamoshi Gambid adapter to simply the Gamoshi adapter This is a minor branding change to highlight the Gamoshi brand name. The biddercode "gambid" is still retained in the adapter aliases array. * update whitelabel * Add test that checks support for outstream renderers * Update testing and page ref * Modify bidder's url resolving * Fix lint issue with bidder's url resolving
Type of change
Description of change
Added two new aliases for Gamoshi adapter: gambid, cleanmedia. Added unit tests.