Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gambid aliases #3410

Merged
merged 13 commits into from
Jan 10, 2019
Merged

Update gambid aliases #3410

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7d239e5
Merge pull request #1 from prebid/master
arikkfir Aug 29, 2018
1f54dd4
Merge branch 'master' of github.com:gamoshi/Prebid.js
Sep 5, 2018
678beb6
Update the Gamoshi Gambid adapter to simply the Gamoshi adapter
Sep 5, 2018
1eff2e5
Merge branch 'master' of https://github.com/prebid/Prebid.js
mmoses Oct 20, 2018
4ec42f0
Merge branch 'master' into update-gambid-aliases
mmoses Oct 20, 2018
4f99bbe
update whitelabel
mmoses Oct 20, 2018
decb789
Merge remote-tracking branch 'prebid/master'
mmoses Dec 26, 2018
20e2ce6
Merge branch 'master' into update-gambid-aliases
mmoses Dec 26, 2018
e8c98f6
Add test that checks support for outstream renderers
sa1omon Dec 27, 2018
c25cb46
Update testing and page ref
mmoses Dec 27, 2018
ba4a5b1
Modify bidder's url resolving
sa1omon Jan 6, 2019
0055ba8
Merge remote-tracking branch 'upstream/master' into update-gambid-ali…
sa1omon Jan 7, 2019
de1db68
Fix lint issue with bidder's url resolving
sa1omon Jan 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
122 changes: 65 additions & 57 deletions modules/gambidBidAdapter.js → modules/gamoshiBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,65 +1,73 @@
import * as utils from 'src/utils';
import { registerBidder } from 'src/adapters/bidderFactory';
import { config } from 'src/config';
import { Renderer } from '../src/Renderer';
import {registerBidder} from 'src/adapters/bidderFactory';
import {config} from 'src/config';
import {Renderer} from '../src/Renderer';

function getTopFrame() {
try {
return window.top === window ? 1 : 0;
} catch (e) {
export const helper = {

getTopFrame: function () {
try {
return window.top === window ? 1 : 0;
} catch (e) {
}
return 0;
}
}
},

function startsWith(str, search) {
return str.substr(0, search.length) === search;
}
startsWith: function (str, search) {
return str.substr(0, search.length) === search;
},

function getTopWindowDomain() {
const url = utils.getTopWindowUrl();
const domainStart = url.indexOf('://') + '://'.length;
return url.substring(domainStart, url.indexOf('/', domainStart) < 0 ? url.length : url.indexOf('/', domainStart));
}
getTopWindowDomain: function (url) {
const domainStart = url.indexOf('://') + '://'.length;
return url.substring(domainStart, url.indexOf('/', domainStart) < 0 ? url.length : url.indexOf('/', domainStart));
},

function getTopWindowReferer() {
try {
return window.top.document.referrer;
} catch (e) {
utils.logMessage('Failed obtaining top window\'s referrer: ', e);
getTopWindowReferer: function () {
try {
return window.document.referrer;
return window.top.document.referrer;
} catch (e) {
utils.logMessage('Failed obtaining current window\'s referrer: ', e);
return '';
utils.logMessage('Failed obtaining top window\'s referrer: ', e);
try {
return window.document.referrer;
} catch (e) {
utils.logMessage('Failed obtaining current window\'s referrer: ', e);
}
}
return '';
}
}

export const spec = {
code: 'gambid',
aliases: [],
supportedMediaTypes: [ 'banner', 'video' ],
code: 'gamoshi',
aliases: ['gambid', 'cleanmedia'],
supportedMediaTypes: ['banner', 'video'],

isBidRequestValid: function(bid) {
isBidRequestValid: function (bid) {
return !!bid.params.supplyPartnerId && typeof bid.params.supplyPartnerId === 'string' &&
(typeof bid.params[ 'rtbEndpoint' ] === 'undefined' || typeof bid.params[ 'rtbEndpoint' ] === 'string') &&
(typeof bid.params.bidfloor === 'undefined' || typeof bid.params.bidfloor === 'number') &&
(typeof bid.params[ 'adpos' ] === 'undefined' || typeof bid.params[ 'adpos' ] === 'number') &&
(typeof bid.params[ 'protocols' ] === 'undefined' || Array.isArray(bid.params[ 'protocols' ])) &&
(typeof bid.params.instl === 'undefined' || bid.params.instl === 0 || bid.params.instl === 1);
(typeof bid.params['rtbEndpoint'] === 'undefined' || typeof bid.params['rtbEndpoint'] === 'string') &&
(typeof bid.params.bidfloor === 'undefined' || typeof bid.params.bidfloor === 'number') &&
(typeof bid.params['adpos'] === 'undefined' || typeof bid.params['adpos'] === 'number') &&
(typeof bid.params['protocols'] === 'undefined' || Array.isArray(bid.params['protocols'])) &&
(typeof bid.params.instl === 'undefined' || bid.params.instl === 0 || bid.params.instl === 1);
},

buildRequests: function(validBidRequests, bidderRequest) {
buildRequests: function (validBidRequests, bidderRequest) {
return validBidRequests.map(bidRequest => {
const { adUnitCode, auctionId, mediaTypes, params, sizes, transactionId } = bidRequest;
const baseEndpoint = params[ 'rtbEndpoint' ] || 'https://rtb.gambid.io';
const {adUnitCode, auctionId, mediaTypes, params, sizes, transactionId} = bidRequest;
const baseEndpoint = params['rtbEndpoint'] || 'https://rtb.gamoshi.io';
const rtbEndpoint = `${baseEndpoint}/r/${params.supplyPartnerId}/bidr?rformat=open_rtb&reqformat=rtb_json&bidder=prebid` + (params.query ? '&' + params.query : '');
let url = config.getConfig('pageUrl');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config.getConfig('pageUrl') will never be used because if it exists it will trigger the else block below where it's reset to utils.getTopWindowUrl()
maybe:
let url = config.getConfig('pageUrl') || bidderRequest && bidderRequest.refererInfo && bidderRequest.refererInfo.referer || utils.getTopWindowUrl();

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which means there must not be a test verifying the expected behavior.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harpere fixed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sa1omon I don't see any new commits.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harpere please check it again now.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sa1omon - Sorry, logically that should work, but lint doesn't like it. CircleCI error: Unexpected mix of '||' and '&&' no-mixed-operators.

if (!url && bidderRequest && bidderRequest.refererInfo && bidderRequest.refererInfo.referer) {
url = bidderRequest.refererInfo.referer;
} else {
url = utils.getTopWindowUrl();
}
const rtbBidRequest = {
'id': auctionId,
'site': {
'domain': getTopWindowDomain(),
'page': config.getConfig('pageUrl') || utils.getTopWindowUrl(),
'ref': getTopWindowReferer()
'domain': helper.getTopWindowDomain(url),
'page': url,
'ref': helper.getTopWindowReferer()
},
'device': {
'ua': navigator.userAgent
Expand All @@ -80,33 +88,33 @@ export const spec = {
'tagid': adUnitCode,
'bidfloor': params.bidfloor || 0,
'bidfloorcur': 'USD',
'secure': startsWith(utils.getTopWindowUrl().toLowerCase(), 'http://') ? 0 : 1
'secure': helper.startsWith(utils.getTopWindowUrl().toLowerCase(), 'http://') ? 0 : 1
};

if (!mediaTypes || mediaTypes.banner) {
imp.banner = {
w: sizes.length ? sizes[ 0 ][ 0 ] : 300,
h: sizes.length ? sizes[ 0 ][ 1 ] : 250,
w: sizes.length ? sizes[0][0] : 300,
h: sizes.length ? sizes[0][1] : 250,
pos: params.pos || 0,
topframe: getTopFrame()
topframe: helper.getTopFrame()
};
} else if (mediaTypes.video) {
imp.video = {
w: sizes.length ? sizes[ 0 ][ 0 ] : 300,
h: sizes.length ? sizes[ 0 ][ 1 ] : 250,
w: sizes.length ? sizes[0][0] : 300,
h: sizes.length ? sizes[0][1] : 250,
protocols: params.protocols || [1, 2, 3, 4, 5, 6],
pos: params.pos || 0,
topframe: getTopFrame()
topframe: helper.getTopFrame()
};
} else {
return;
}
rtbBidRequest.imp.push(imp);
return { method: 'POST', url: rtbEndpoint, data: rtbBidRequest, bidRequest };
return {method: 'POST', url: rtbEndpoint, data: rtbBidRequest, bidRequest};
});
},

interpretResponse: function(serverResponse, bidRequest) {
interpretResponse: function (serverResponse, bidRequest) {
const response = serverResponse && serverResponse.body;
if (!response) {
utils.logError('empty response');
Expand All @@ -127,7 +135,7 @@ export const spec = {
currency: bid.cur || response.cur
};
if (!bidRequest.bidRequest.mediaTypes || bidRequest.bidRequest.mediaTypes.banner) {
outBids.push(Object.assign({}, outBid, { mediaType: 'banner', ad: bid.adm }));
outBids.push(Object.assign({}, outBid, {mediaType: 'banner', ad: bid.adm}));
} else if (bidRequest.bidRequest.mediaTypes.video) {
const context = utils.deepAccess(bidRequest.bidRequest, 'mediaTypes.video.context');
outBids.push(Object.assign({}, outBid, {
Expand All @@ -141,27 +149,27 @@ export const spec = {
return outBids;
},

getUserSyncs: function(syncOptions, serverResponses, gdprConsent) {
getUserSyncs: function (syncOptions, serverResponses, gdprConsent) {
const syncs = [];
const gdprApplies = gdprConsent && (typeof gdprConsent.gdprApplies === 'boolean') ? gdprConsent.gdprApplies : false;
const suffix = gdprApplies ? 'gc=' + encodeURIComponent(gdprConsent.consentString) : 'gc=missing';
serverResponses.forEach(resp => {
if (resp.body) {
const bidResponse = resp.body;
if (bidResponse.ext && Array.isArray(bidResponse.ext[ 'utrk' ])) {
bidResponse.ext[ 'utrk' ].forEach(pixel => {
if (bidResponse.ext && Array.isArray(bidResponse.ext['utrk'])) {
bidResponse.ext['utrk'].forEach(pixel => {
const url = pixel.url + (pixel.url.indexOf('?') > 0 ? '&' + suffix : '?' + suffix);
return syncs.push({ type: pixel.type, url });
return syncs.push({type: pixel.type, url});
});
}
if (Array.isArray(bidResponse.seatbid)) {
bidResponse.seatbid.forEach(seatBid => {
if (Array.isArray(seatBid.bid)) {
seatBid.bid.forEach(bid => {
if (bid.ext && Array.isArray(bid.ext[ 'utrk' ])) {
bid.ext[ 'utrk' ].forEach(pixel => {
if (bid.ext && Array.isArray(bid.ext['utrk'])) {
bid.ext['utrk'].forEach(pixel => {
const url = pixel.url + (pixel.url.indexOf('?') > 0 ? '&' + suffix : '?' + suffix);
return syncs.push({ type: pixel.type, url });
return syncs.push({type: pixel.type, url});
});
}
});
Expand Down
16 changes: 8 additions & 8 deletions modules/gambidBidAdapter.md → modules/gamoshiBidAdapter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
# Overview

```
Module Name: Gamoshi's Gambid Bid Adapter
Module Name: Gamoshi Bid Adapter
Module Type: Bidder Adapter
Maintainer: arik@gamoshi.com
Maintainer: moses@gamoshi.com
```

# Description

Connects to Gamoshi's Gambid platform & exchange for bids.
Connects to Gamoshi's Programmatic advertising platform as a service.

Gambid bid adapter supports Banner & Outstream Video. The *only* required parameter (in the `params` section) is the `supplyPartnerId` parameter.
Gamoshi bid adapter supports Banner & Outstream Video. The *only* required parameter (in the `params` section) is the `supplyPartnerId` parameter.

# Test Parameters
```
Expand All @@ -21,10 +21,10 @@ var adUnits = [
code: 'banner-div',
sizes: [[300, 250]],
bids: [{
bidder: 'gambid',
bidder: 'gamoshi',
params: {

// ID of the supply partner you created in the Gambid dashboard
// ID of the supply partner you created in the Gamoshi dashboard
supplyPartnerId: '1253',

// OPTIONAL: if you have a whitelabel account on Gamoshi, specify it here
Expand Down Expand Up @@ -55,10 +55,10 @@ var adUnits = [
}
},
bids: [ {
bidder: 'gambid',
bidder: 'gamoshi',
params: {

// ID of the supply partner you created in the Gambid dashboard
// ID of the supply partner you created in the dashboard
supplyPartnerId: '1254',

// OPTIONAL: if you have a whitelabel account on Gamoshi, specify it here
Expand Down
Loading