Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No bid version 1.2.5 #5137

Merged
merged 13 commits into from
Apr 22, 2020
Merged

No bid version 1.2.5 #5137

merged 13 commits into from
Apr 22, 2020

Conversation

redaguermas
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Implemented Video support in the NoBid Prebid Adapter.

Other information

@redaguermas
Enable supplyChain support
0eba11e
@redaguermas
Added support for COPPA
c0fb8ee
@redaguermas
Merge branch 'master' of https://github.com/prebid/Prebid.js
36fab76 
* 'master' of https://github.com/prebid/Prebid.js: (49 commits)
  Submitting Clicktripz bid adapter (prebid#4929)
  add UNICORN bid adapter (prebid#4917)
  3.12.0-pre
  3.11.0 release
  Eids liveintent ext fix (prebid#4944)
  add mediaforce bid adapter (prebid#4933)
  update logic in adpod module for playersize (prebid#4953)
  Module - Size Mapping V2 (prebid#4690)
  Lifestreet adapter 3.0 (prebid#4927)
  IX Adapter - Increase banner TTL to 300s (prebid#4957)
  assert string returned not that we break things (prebid#4962)
  added option to url parser to ignore decoding entire url (prebid#4938)
  adding user-id support in medianet adapter (prebid#4925)
  removing the log (prebid#4960)
  add import extensions (prebid#4959)
  Add 7xbid adapter to compatible with prebid 3.0 (prebid#4908)
  Fix failing code-coverage command (prebid#4892)
  enable no-console eslint rule for project (prebid#4802)
  update audigent tests to fix larger test suite issue (prebid#4952)
  use bidId or bidIds in the payload (prebid#4903)
  ...
@redaguermas
Merge branch 'master' of https://github.com/prebid/Prebid.js
51525d7 
* 'master' of https://github.com/prebid/Prebid.js: (102 commits)
  Marsmedia - Add vastXml and fix id response (prebid#5067)
  PubMatic adapter to support image sync (prebid#5104)
  minor consentManagement fix (prebid#5050)
  fix circle ci failing tests (prebid#5113)
  Add Relaido Adapter (prebid#5101)
  Add new bid adapter for ConnectAd (prebid#4806)
  change payload (prebid#5105)
  Utils updates (prebid#5092)
  Read OpenRTB app objects if set in config + bug fix for when ad units are reloaded (prebid#5086)
  Criteo : added first party data mapping to bidder request (prebid#4954)
  updateAdGenerationManual (prebid#5032)
  New bid adapter: Wipes (prebid#5051)
  Prebid manager analytics utm tags (prebid#4998)
  CRITEO RTUS Integration with Yieldmo Prebid (prebid#5075)
  isSafariBrowser update  (prebid#5077)
  Support min &max duration for onevideo (prebid#5079)
  increment pre version
  Prebid 3.15.0 release
  prebid#5011 Fix to set Secure attribute on cookie when SameSite=none (prebid#5064)
  Prebid adapter for windtalker (prebid#5040)
  ...
@redaguermas
Added support for video ad type
2a7ee10
@lgtm-com
Copy link

lgtm-com bot commented Apr 17, 2020

This pull request introduces 1 alert when merging 2a7ee10 into 250dd1d - view on LGTM.com

new alerts:

  • 1 for Useless conditional

@lgtm-com
Copy link

lgtm-com bot commented Apr 17, 2020

This pull request introduces 1 alert when merging bb803ca into 2efa352 - view on LGTM.com

new alerts:

  • 1 for Useless conditional

@lgtm-com
Copy link

lgtm-com bot commented Apr 17, 2020

This pull request introduces 1 alert when merging c489025 into bd9243c - view on LGTM.com

new alerts:

  • 1 for Useless conditional

@redaguermas
Copy link
Contributor Author

Can someone help me with the CI/Circle errors. They seem to be related to another package

@redaguermas
Merge branch 'master' of https://github.com/prebid/Prebid.js
6b11e52 
* 'master' of https://github.com/prebid/Prebid.js:
  Revert "New LuponMedia Bid Adapter (prebid#5120)" (prebid#5145)
  New LuponMedia Bid Adapter (prebid#5120)
  Feature/send publisher domain (prebid#5121)
  update test adunit params (prebid#5135)
  add parameter to the conversant adapter to override the url (prebid#5133)
  Replace call to old url module with call to utils (prebid#5136)
  GumGum: uses encodeURIComponent inline (prebid#5124)
  User ID's (liveramp, britepool) and gdpr (prebid#5114)
  fix wipes adapter response (prebid#5134)
  Submitting Tercept Analytics Adapter (prebid#5099)
  hotfix - undefined consent (prebid#5127)
  parrableIdSystem: Send current page location to back-end (prebid#5123)
  Increment pre version
  Prebid 3.16.0 Release
  Use a deepmerge function to merge both globa level config & bidder specific config (prebid#5039)
  Update appnexusBidAdapter.js (prebid#4893)
  Quantcast: Block bids without purpose 1 consent (prebid#5046)
  ShowHeroes adapter v2 (prebid#5085)
  Qc/qc usersyncs (prebid#4923)
@redaguermas
Merge branch 'master' into NoBid-Version-1.2.5
9d0db06 
* master:
  Revert "New LuponMedia Bid Adapter (prebid#5120)" (prebid#5145)
  New LuponMedia Bid Adapter (prebid#5120)
  Feature/send publisher domain (prebid#5121)
  update test adunit params (prebid#5135)
  add parameter to the conversant adapter to override the url (prebid#5133)
  Replace call to old url module with call to utils (prebid#5136)
  GumGum: uses encodeURIComponent inline (prebid#5124)
  User ID's (liveramp, britepool) and gdpr (prebid#5114)
  fix wipes adapter response (prebid#5134)
  Submitting Tercept Analytics Adapter (prebid#5099)
  hotfix - undefined consent (prebid#5127)
  parrableIdSystem: Send current page location to back-end (prebid#5123)
  Increment pre version
  Prebid 3.16.0 Release
  Use a deepmerge function to merge both globa level config & bidder specific config (prebid#5039)
  Update appnexusBidAdapter.js (prebid#4893)
  Quantcast: Block bids without purpose 1 consent (prebid#5046)
  ShowHeroes adapter v2 (prebid#5085)
  Qc/qc usersyncs (prebid#4923)
@redaguermas
Copy link
Contributor Author

After merge from master I am getting an error from this Adapter test "colossussspBidAdapter_spec". Can someone resolve this issue please...

@redaguermas
Copy link
Contributor Author

@harpere , @FilipStamenkovic ,
Can you please review my pull request? It seems that there is a problem with this adapter "colossussspBidAdapter_spec" and it's blocking my pull request. Can you please advise what should we do to resolve this issue?

@FilipStamenkovic
Copy link
Contributor

I’ll review this PR first thing tomorrow morning.

FilipStamenkovic
FilipStamenkovic reviewed Apr 21, 2020
View reviewed changes
Copy link
Contributor

@FilipStamenkovic FilipStamenkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that title of this PR is 'No bid version 1.2.5'.
But, in your changes you didn't increment version, so in the code it is still 1.2.4.
Is this on purpose?

All in all, this PR looks good to me, I just left one comment to use already defined constant instead of hardcoded string. Other comment is just a consideration, you don't need to change there anything.

modules/nobidBidAdapter.js Outdated Show resolved Hide resolved
modules/nobidBidAdapter.js Outdated Show resolved Hide resolved
@FilipStamenkovic
Copy link
Contributor

"colossussspBidAdapter_spec" and it's blocking my pull request. Can you please advise what should we do to resolve this issue?

I'm not sure what is going on with circleci, nor why tests in colossussspBidAdapter_spec are failing, but I see that this has nothing to do with this PR, and tests are passing for your adapter. So, I wouldn't worry about failed tests on circleci.

@redaguermas
Copy link
Contributor Author

@FilipStamenkovic ,
Can you please review?
Thank you

@FilipStamenkovic FilipStamenkovic merged commit e8d3119 into prebid:master Apr 22, 2020
iggyfisk pushed a commit to happypancake/Prebid.js that referenced this pull request Jun 22, 2020
@redaguermas @iggyfisk
No bid version 1.2.5 (prebid#5137)
a4860fe 
* Enable supplyChain support

* Added support for COPPA

* Added support for video ad type

* Fix lint errors

* Fix lint

* Removed "useless condition"

* Using ddepAccess and fixed version to 1.2.5

* Fix lint

* Fixed vidoe test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FilipStamenkovic FilipStamenkovic FilipStamenkovic approved these changes

Assignees

@FilipStamenkovic FilipStamenkovic

Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@redaguermas @FilipStamenkovic @harpere