Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Triplelift: expose tl_souce in bid response #5139

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Triplelift: expose tl_souce in bid response #5139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4657870
expose tl_souce in bid response
iam-sydao Apr 17, 2020
d81b71f
update TLL to 300
iam-sydao Apr 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/tripleliftBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,8 @@ function _buildResponseObject(bidderRequest, bid) {
creativeId: creativeId,
dealId: dealId,
currency: 'USD',
ttl: 33,
ttl: 300,
tl_source: bid.tl_source,
};
};
return bidResponse;
Expand Down
19 changes: 13 additions & 6 deletions test/spec/modules/tripleliftBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,8 @@ describe('triplelift adapter', function () {
width: 300,
height: 250,
ad: 'ad-markup',
iurl: 'https://s.adroll.com/a/IYR/N36/IYRN366MFVDITBAGNNT5U6.jpg'
iurl: 'https://s.adroll.com/a/IYR/N36/IYRN366MFVDITBAGNNT5U6.jpg',
tl_source: 'tlx',
}
]
}
Expand All @@ -327,7 +328,8 @@ describe('triplelift adapter', function () {
width: 300,
height: 250,
ad: 'ad-markup',
iurl: 'https://s.adroll.com/a/IYR/N36/IYRN366MFVDITBAGNNT5U6.jpg'
iurl: 'https://s.adroll.com/a/IYR/N36/IYRN366MFVDITBAGNNT5U6.jpg',
tl_source: 'tlx',
}
],
refererInfo: {
Expand All @@ -352,6 +354,7 @@ describe('triplelift adapter', function () {
dealId: '',
currency: 'USD',
ttl: 33,
tl_source: 'tlx',
}
];
let result = tripleliftAdapterSpec.interpretResponse(response, {bidderRequest});
Expand All @@ -369,15 +372,17 @@ describe('triplelift adapter', function () {
width: 300,
height: 250,
ad: 'ad-markup',
iurl: 'https://s.adroll.com/a/IYR/N36/IYRN366MFVDITBAGNNT5U6.jpg'
iurl: 'https://s.adroll.com/a/IYR/N36/IYRN366MFVDITBAGNNT5U6.jpg',
tl_source: 'tlx',
},
{
imp_id: 0,
cpm: 1.9,
width: 300,
height: 600,
ad: 'ad-markup-2',
iurl: 'https://s.adroll.com/a/IYR/N36/IYRN366MFVDITBAGNNT5U6.jpg'
iurl: 'https://s.adroll.com/a/IYR/N36/IYRN366MFVDITBAGNNT5U6.jpg',
tl_source: 'tlx',
}
]
}
Expand All @@ -393,15 +398,17 @@ describe('triplelift adapter', function () {
width: 300,
height: 600,
ad: 'ad-markup',
iurl: 'https://s.adroll.com/a/IYR/N36/IYRN366MFVDITBAGNNT5U6.jpg'
iurl: 'https://s.adroll.com/a/IYR/N36/IYRN366MFVDITBAGNNT5U6.jpg',
tl_source: 'tlx',
},
{
imp_id: 0,
cpm: 1.9,
width: 300,
height: 250,
ad: 'ad-markup-2',
iurl: 'https://s.adroll.com/a/IYR/N36/IYRN366MFVDITBAGNNT5U6.jpg'
iurl: 'https://s.adroll.com/a/IYR/N36/IYRN366MFVDITBAGNNT5U6.jpg',
tl_source: 'tlx',
}
],
refererInfo: {
Expand Down