Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Triplelift: expose tl_souce in bid response #5139

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Triplelift: expose tl_souce in bid response #5139

merged 2 commits into from
Apr 22, 2020

Conversation

sdao-tl
Copy link
Contributor

@sdao-tl sdao-tl commented Apr 17, 2020 •
edited
Loading

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • Expose 'tl_source' from 3lift bid response to prebid response
  • Update TTL to 300

Other information

@mike-chowla mike-chowla self-assigned this Apr 22, 2020
@mike-chowla mike-chowla self-requested a review April 22, 2020 20:01
mike-chowla
mike-chowla approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike-chowla mike-chowla merged commit 2477e86 into prebid:master Apr 22, 2020
banesto pushed a commit to banesto/Prebid.js that referenced this pull request Apr 27, 2020
Merge commit '8db2720d60a6533dee52e96f847854ef1c219345'
b94bd8d 
* commit '8db2720d60a6533dee52e96f847854ef1c219345': (249 commits)
  Release 3.17.0
  LunaMedia Adapter (prebid#5110)
  UserId module to export user ids as eids with pbjs.getUserIdsAsEids() (prebid#5108)
  Triplelift: expose tl_souce in bid response (prebid#5139)
  Add warning messages for publishers while native ads send assets containing url without sendId  (prebid#5096)
  use customSlotMatching func for reseting targeting (prebid#5132)
  Teads fix production GDPR error (prebid#5122)
  No bid version 1.2.5 (prebid#5137)
  SublimeBidAdapter src/url.js import fix (prebid#5150)
  Improve Digital adapter: add support for outstream video (prebid#5129)
  Disallowing remote requests from Safari and Firefox due to browsers no longer supporting DigiTrust ID. (prebid#5109)
  PS bid adapter update to copy site object from config (prebid#5083)
  SublimeBidAdapter: Update to version 0.5.1 (prebid#4977)
  LuponMedia Bid Adapter (prebid#5146)
  [BUGFIX] AdagioBidAdapter getDataFromLocalStorage (prebid#5081)
  Revert "New LuponMedia Bid Adapter (prebid#5120)" (prebid#5145)
  New LuponMedia Bid Adapter (prebid#5120)
  Feature/send publisher domain (prebid#5121)
  update test adunit params (prebid#5135)
  add parameter to the conversant adapter to override the url (prebid#5133)
  ...
iggyfisk pushed a commit to happypancake/Prebid.js that referenced this pull request Jun 22, 2020
@sdao-tl @iam-sydao @iggyfisk
Triplelift: expose tl_souce in bid response (prebid#5139)
0b7362c 
* expose tl_souce in bid response

* update TLL to 300

Co-authored-by: Sy Dao <iam.sydao@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-chowla mike-chowla mike-chowla approved these changes

Assignees

@mike-chowla mike-chowla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdao-tl @mike-chowla @iam-sydao