ucfunnel Bid Adapter: add support Price Floors Module #6806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Replace var with let 3. Put JSON.parse(JSON.stringify()) into try catch block
Merge the latest changes 9/25/2017
|
@jackhsiehucf browserstack seems to be hanging on this pr and another one I have come across and that is messing with testing. Trying to figure out what exactly the issue is. |
|
Thanks for this PR, I removed changes to your adapter from #6804 |
patmmccann
reviewed
May 21, 2021
| if (typeof bid.getFloor === 'function') { | ||
| var bidFloor = bid.getFloor({ | ||
| currency: CURRENCY, | ||
| mediaType: getMediaType(mediaTypes), |
There was a problem hiding this comment.
On multiformat unit, this appears to always set the video floor.
There was a problem hiding this comment.
@patmmccann Does multiformat unit mean that adUnits support multiple mediaType ?
Like support banner and video in the same adUnits.
There was a problem hiding this comment.
I update the commit to fix the banner bid floor problem.
There was a problem hiding this comment.
@patmmccann any comment about the update commit?
ChrisHuie
approved these changes
Jun 1, 2021
AlvaroBrey
pushed a commit
to Parrable/Prebid.js
that referenced
this pull request
Jun 2, 2021
…FilterStatus' into PBID-96_requestFilterStatus * origin/parrableIdSystem/PBID-96_requestFilterStatus: (63 commits) Smaato bid adapter: Rework multi imp support (prebid#6814) Adot Bid Adapter: add the advertising domains support (prebid#6876) Update Adtelligent, Adtarget, ViewDeos adapters to support adomain (prebid#6917) LockerDome Bid Adapter: support for meta.advertiserDomains (prebid#6921) Sublime Bid Adapter : Add support for meta.advertiserDomains (prebid#6920) Brightcom Bid Adapter: use getFloor function (prebid#6918) AdYouLike Bidder: Handle advertiser domains (prebid#6916) relaido Bid Adapter: Add meta OBJ to BidResponse (prebid#6914) Jixie Bid Adapter: add support for advertiserDomains (prebid#6898) Onomagic Bid Adapter: use getFloor function (prebid#6907) Sharethrough Bid Adapter: Use getFloor module for Prebid 5.0 compliance (prebid#6874) Accept outstream renderers defined in mediatype for PBS (prebid#6896) Yieldmo Bid Adapter: read video parameters from the ad unit (prebid#6873) smartx Bid Adapter: Add support for Floors Module (prebid#6902) add support for advertiser domains (prebid#6908) Onomagic Bid Adapter: handle meta.advertiserDomains (prebid#6906) Brightcom Bid Adapter: handle meta.advertiserDomains (prebid#6905) ucfunnel Bid Adapter: add support Price Floors Module (prebid#6806) eTarget Bid Adapter: add "getMetaData" function to adapter, support for advertiserDomains (prebid#6901) AdagioBidAdapter: support priceFloors module (prebid#6867) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information