-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ucfunnel Bid Adapter: add support Price Floors Module #6806
Merged
Merged
Changes from all commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
d18db95
Add a new ucfunnel Adapter and test page
f82a4b7
Add a new ucfunnel Adapter and test page
4c91775
1. Use prebid lib in the repo to keep updated
RyanChouTw 52eaecb
Merge branch 'master' into master
RyanChouTw 96a70a4
utils.getTopWindowLocation is a function
RyanChouTw 7202a62
Merge branch 'master' of https://github.com/prebid/Prebid.js
RyanChouTw 858b833
Change to modules from adapters
RyanChouTw 8b46932
Migrate to module design
RyanChouTw d7e043b
[Dev Fix] Remove width and height which can be got from ad unit id
RyanChouTw badfa53
Merge branch 'master' of https://github.com/prebid/Prebid.js
RyanChouTw 8d81704
Merge pull request #1 from prebid/master
RyanChouTw 8e7fe31
Merge branch 'master' of https://github.com/prebid/Prebid.js
RyanChouTw 5dc00f3
Update ucfunnelBidAdapter to fit into new spec
RyanChouTw 66c3a06
Correct the endpoint. Fix the error of query string
RyanChouTw 0328e97
Add test case for ucfunnelBidAdapter
RyanChouTw c2c5eb0
Merge branch 'master' of https://github.com/prebid/Prebid.js
RyanChouTw 86fdd23
Fix lint error
RyanChouTw c331f57
Update version number
RyanChouTw 28acb40
Combine all checks on bid request
RyanChouTw 93621b8
Merge branch 'master' of https://github.com/prebid/Prebid.js
RyanChouTw f7f2515
Add GDPR support for ucfunnel adapter
RyanChouTw d4f3467
Merge branch 'master' of https://github.com/prebid/Prebid.js
RyanChouTw 1f79c44
Add in-stream video and native support for ucfunnel adapter
RyanChouTw 7d8dc52
Remove demo page. Add more test cases.
RyanChouTw 99fa86e
Change request method from POST to GET
RyanChouTw 03e37e6
Remove unnecessary comment
RyanChouTw aabfdd4
Support vastXml and vastUrl for video request
RyanChouTw 2177c15
Merge branch 'master' of https://github.com/prebid/Prebid.js
af05d07
update TTL to 30 mins
45614c9
Avoid using arrow function which is not discuraged in mocha
a5b402c
Merge branch 'master' of https://github.com/prebid/Prebid.js
c22723e
ucfunnel tdid support
644b900
Merge branch 'master' of https://github.com/prebid/Prebid.js into HEAD
0175c57
ucfunnel fix error message in debug mode
70e82bb
Merge branch 'master' of https://github.com/prebid/Prebid.js
jackhsiehucf c09b816
ucfunnel adapter add bidfloor parameter
jackhsiehucf 30e79c5
Merge branch 'master' of https://github.com/prebid/Prebid.js into ccpa
jackhsiehucf fee3803
ucfunnel adapter support CCPA
jackhsiehucf 0f9b6c8
ucfunnel adapter fix prebid 3.0 problem
jackhsiehucf eb11188
merge
jackhsiehucf 994ffef
Merge branch 'master' of https://github.com/prebid/Prebid.js
jackhsiehucf 084190b
ucfunnel adapter native support clicktrackers
jackhsiehucf ddb077d
Merge branch 'master' of https://github.com/prebid/Prebid.js
jackhsiehucf bb22940
ucfunnel adapter change cookie sync setting
jackhsiehucf 3004ad9
Merge branch 'master' of https://github.com/prebid/Prebid.js
jackhsiehucf f34f753
ucfunnel adapter update request parameter
jackhsiehucf 0f8cba0
Merge branch 'master' of https://github.com/prebid/Prebid.js
jackhsiehucf 0b34007
Update ucfunnelBidAdapter
jackhsiehucf 08f7de0
Merge branch 'master' of https://github.com/prebid/Prebid.js
jackhsiehucf 85bf436
ucfunnel adapter add currency in ad response
jackhsiehucf b6b7ab0
Merge branch 'master' of https://github.com/prebid/Prebid.js
jackhsiehucf c2d5bb3
ucfunnel adapter support uid2
jackhsiehucf 8eea4b5
Merge branch 'master' of https://github.com/prebid/Prebid.js
jackhsiehucf 8630cb1
ucfunnel Bid Adapter: add support for FLoC and Verizon Media ConnectID
jackhsiehucf 97421e1
Merge branch 'master' of https://github.com/prebid/Prebid.js
jackhsiehucf 5829658
ucfunnel Bid Adapter: add support Price Floors Module
jackhsiehucf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On multiformat unit, this appears to always set the video floor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patmmccann Does multiformat unit mean that adUnits support multiple mediaType ?
Like support banner and video in the same adUnits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I update the commit to fix the banner bid floor problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patmmccann any comment about the update commit?