Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ThoughtLeadr adapter #894

Merged
merged 2 commits into from
Feb 16, 2017
Merged

Add ThoughtLeadr adapter #894

merged 2 commits into from
Feb 16, 2017

Conversation

ilya-pirogov
Copy link
Contributor

@ilya-pirogov ilya-pirogov commented Dec 24, 2016 •
edited
Loading

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other

Description of change

Added ThoughtLeadr adapter

  • test parameters for validating bids
{
  bidder: 'thoughtleadr',
  params: {
    placementId: 'mock-provider-zemanta'
  }
}

Other information

matthewlane
matthewlane reviewed Jan 5, 2017
View reviewed changes
Copy link
Collaborator

@matthewlane matthewlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the adapter PR. I was able to validate bids and tests pass on browsers we support with the exception of IE9. I noted the line below for your review. Once tests are passing there we should be good to merge

test/spec/adapters/thoughtleadr_spec.js
chai_1.expect(ev.data.TLDR_REQUEST.rid).to.be.equal(rid);
}
else {
throw new Error("should not be any other messages");
Copy link
Collaborator

@matthewlane matthewlane Jan 5, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running tests against IE9 trips up here. I haven't dug deep enough to find a more elegant way of fixing it, but changing the line to done() makes the test pass across browsers, though it may not be what you want. Are you able to run tests on IE9 and/or know of a cross-browser way of addressing this?

@matthewlane matthewlane added this to the Prebid 0.18.0 milestone Jan 6, 2017
@matthewlane
Copy link
Collaborator

@ilya-pirogov Any updates? I'd like to get this into the next release

@Shakakai
Copy link

@matthewlane We're working on a fix to the IE9 issue. We've run into a bit of a snag with BrowserStack. I'll reach out with @ilya-pirogov when we have it figured out.

@mkendall07
Copy link
Member

if this is waiting on an IE 9 fix we can proceed without it. @Shakakai can you resolve conflicts please?

@mkendall07 mkendall07 modified the milestones: Backlog, Prebid 0.19.0 Feb 9, 2017
@Shakakai
Copy link

@mkendall07 Conflicts resolved.

@matthewlane matthewlane merged commit 9721812 into prebid:master Feb 16, 2017
@matthewlane
Copy link
Collaborator

This is merged into master. Please submit a PR to the docs repo to add a file for your adapter to the bidders directory so your adapter's params will appear on the bidders page. Thank you for contributing

@aneuway2
Copy link
Contributor

aneuway2 commented Mar 3, 2017

Hi @ilya-pirogov - Looks like this was just released into Prebid 0.20 (congrats!) but there's no documentation. Can you submit a PR to the doc repo so that we can point potential clients to your adapter?

Thanks!

Walexander pushed a commit to MbidIO/Prebid.js that referenced this pull request Mar 6, 2017
@ilya-pirogov
Add ThoughtLeadr adapter (prebid#894)
800063b
vzhukovsky added a commit to aol/Prebid.js that referenced this pull request May 19, 2017
@vzhukovsky
Merge pull request prebid#88 in AOLP_ADS_JS/prebid.js from release/1.…
7c00979 
…18.0 to aolgithub-master

* commit '2881f03dd76bfcf484fbfeaf0f9e1000b383d20d':
  Added adapters in aolPartnersIds.json.
  Added changelog entry.
  Prebid 0.20.0 Release
  Remove test that intermittently fails unit tests (prebid#1020)
  Create bids for requests without mutating ad units (prebid#1019)
  Use optimize js to improve parse time (https://github.com/nolanlawson/optimize-js) (prebid#1018)
  Fixes for Centro adapter (prebid#992)
  adbund adapter (prebid#932)
  Fix bug with supporting non-cpm dealId bids. (prebid#1006)
  Added referrer parameter (prebid#966)
  Support Video for GetIntent adapter (prebid#987)
  Currency support for SmartAdServer adapter (prebid#979)
  Deal support for SmartAdServer adapter (prebid#978)
  Skip test causing build failures (prebid#997)
  E2etest concurrency (prebid#982)
  Add ThoughtLeadr adapter (prebid#894)
  Increment Pre Version
vzhukovsky added a commit to aol/Prebid.js that referenced this pull request May 22, 2017
@vzhukovsky
Merge pull request prebid#89 in AOLP_ADS_JS/prebid.js from release/1.…
67f20dd 
…18.0 to master

* commit '2881f03dd76bfcf484fbfeaf0f9e1000b383d20d':
  Added adapters in aolPartnersIds.json.
  Added changelog entry.
  Prebid 0.20.0 Release
  Remove test that intermittently fails unit tests (prebid#1020)
  Create bids for requests without mutating ad units (prebid#1019)
  Use optimize js to improve parse time (https://github.com/nolanlawson/optimize-js) (prebid#1018)
  Fixes for Centro adapter (prebid#992)
  adbund adapter (prebid#932)
  Fix bug with supporting non-cpm dealId bids. (prebid#1006)
  Added referrer parameter (prebid#966)
  Support Video for GetIntent adapter (prebid#987)
  Currency support for SmartAdServer adapter (prebid#979)
  Deal support for SmartAdServer adapter (prebid#978)
  Skip test causing build failures (prebid#997)
  E2etest concurrency (prebid#982)
  Add ThoughtLeadr adapter (prebid#894)
  Increment Pre Version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewlane matthewlane matthewlane approved these changes

Assignees

@matthewlane matthewlane

Labels
None yet
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
6 participants
@ilya-pirogov @matthewlane @Shakakai @mkendall07 @aneuway2 @protonate