Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Centro adapter #992

Merged
merged 8 commits into from
Feb 28, 2017
Merged

Fixes for Centro adapter #992

merged 8 commits into from
Feb 28, 2017

Conversation

Niksok
Copy link
Contributor

@Niksok Niksok commented Feb 16, 2017

Hello!
Add please our fixes for Centro adapter.

Type of change

  • Bugfix

Description of change

Made possible to set bid.unit in config as a string or as a number. Added placementId to jsonp handler name. Added query parameter adapter=prebid to server request. Added location.href as default value for page_url.

  • test parameters for validating bids
{
  bidder: 'centro',
  params: {
    unit: '28136'
  }
}

Other information

Thank you,
CBX

@jaiminpanchal27
Copy link
Collaborator

Looks good. Thanks @Niksok

@jaiminpanchal27 jaiminpanchal27 merged commit 00e673c into prebid:master Feb 28, 2017
Walexander pushed a commit to MbidIO/Prebid.js that referenced this pull request Mar 6, 2017
* Add centro adapter and tests for it.

* fix bug with different types of bid.sectionID and bid.unit from config

* add query parameter adapter=prebid

* update tests for centro adapter
vzhukovsky added a commit to aol/Prebid.js that referenced this pull request May 19, 2017
…18.0 to aolgithub-master

* commit '2881f03dd76bfcf484fbfeaf0f9e1000b383d20d':
  Added adapters in aolPartnersIds.json.
  Added changelog entry.
  Prebid 0.20.0 Release
  Remove test that intermittently fails unit tests (prebid#1020)
  Create bids for requests without mutating ad units (prebid#1019)
  Use optimize js to improve parse time (https://github.com/nolanlawson/optimize-js) (prebid#1018)
  Fixes for Centro adapter (prebid#992)
  adbund adapter (prebid#932)
  Fix bug with supporting non-cpm dealId bids. (prebid#1006)
  Added referrer parameter (prebid#966)
  Support Video for GetIntent adapter (prebid#987)
  Currency support for SmartAdServer adapter (prebid#979)
  Deal support for SmartAdServer adapter (prebid#978)
  Skip test causing build failures (prebid#997)
  E2etest concurrency (prebid#982)
  Add ThoughtLeadr adapter (prebid#894)
  Increment Pre Version
vzhukovsky added a commit to aol/Prebid.js that referenced this pull request May 22, 2017
…18.0 to master

* commit '2881f03dd76bfcf484fbfeaf0f9e1000b383d20d':
  Added adapters in aolPartnersIds.json.
  Added changelog entry.
  Prebid 0.20.0 Release
  Remove test that intermittently fails unit tests (prebid#1020)
  Create bids for requests without mutating ad units (prebid#1019)
  Use optimize js to improve parse time (https://github.com/nolanlawson/optimize-js) (prebid#1018)
  Fixes for Centro adapter (prebid#992)
  adbund adapter (prebid#932)
  Fix bug with supporting non-cpm dealId bids. (prebid#1006)
  Added referrer parameter (prebid#966)
  Support Video for GetIntent adapter (prebid#987)
  Currency support for SmartAdServer adapter (prebid#979)
  Deal support for SmartAdServer adapter (prebid#978)
  Skip test causing build failures (prebid#997)
  E2etest concurrency (prebid#982)
  Add ThoughtLeadr adapter (prebid#894)
  Increment Pre Version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants