PubMatic: Support hardcoded alias #3224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code coverage summaryNote:
pubmaticRefer here for heat map coverage report |
| @@ -640,7 +641,8 @@ func getBidType(bidExt *pubmaticBidExt) openrtb_ext.BidType { | |||
| // Builder builds a new instance of the Pubmatic adapter for the given bidder with the given config. | |||
| func Builder(bidderName openrtb_ext.BidderName, config config.Adapter, server config.Server) (adapters.Bidder, error) { | |||
| bidder := &PubmaticAdapter{ | |||
| URI: config.Endpoint, | |||
| URI: config.Endpoint, | |||
| bidderName: string(bidderName), | |||
There was a problem hiding this comment.
@pm-nilesh-chate , can you add some description about how bidderName is planned to be used
There was a problem hiding this comment.
This is for distinguishing between bidder and adapter name within the Fledge auction object, where hardcore aliases are used for PubMatic bidder which is part of PBS-Core. These changes related to PBS-Core appear straightforward. If you believe adding a comment would be beneficial, I'll include it in the next upcoming PR, which is also related to this.
|
@pm-nilesh-chate prebid server had major release 2.0 requesting to update |
pm-nilesh-chate
force-pushed
the
master
branch
from
ff5b822
to
c9273be
Compare
Code coverage summaryNote:
pubmaticRefer here for heat map coverage report |
done |
|
@onkarvhanumante please review and merge this |
onkarvhanumante
approved these changes
Nov 9, 2023
Sonali-More-Xandr
approved these changes
Nov 13, 2023
bsardo
changed the title
svamiftah
pushed a commit
to sovrn/prebid-server
that referenced
this pull request
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.