Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PubMatic: Support hardcoded alias #3224

Merged
merged 1 commit into from
Nov 16, 2023
Merged

PubMatic: Support hardcoded alias #3224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions adapters/pubmatic/pubmatic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ const MAX_IMPRESSIONS_PUBMATIC = 30
const ae = "ae"

type PubmaticAdapter struct {
URI string
URI string
bidderName string
}

type pubmaticBidExt struct {
Expand Down Expand Up @@ -640,7 +641,8 @@ func getBidType(bidExt *pubmaticBidExt) openrtb_ext.BidType {
// Builder builds a new instance of the Pubmatic adapter for the given bidder with the given config.
func Builder(bidderName openrtb_ext.BidderName, config config.Adapter, server config.Server) (adapters.Bidder, error) {
bidder := &PubmaticAdapter{
URI: config.Endpoint,
URI: config.Endpoint,
bidderName: string(bidderName),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pm-nilesh-chate , can you add some description about how bidderName is planned to be used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for distinguishing between bidder and adapter name within the Fledge auction object, where hardcore aliases are used for PubMatic bidder which is part of PBS-Core. These changes related to PBS-Core appear straightforward. If you believe adding a comment would be beneficial, I'll include it in the next upcoming PR, which is also related to this.

}
return bidder, nil
}
Loading