add workaround to block preinstall for known issue with Electron 4.0.x #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a maintainer on
keytarand had to deal with the Electron 3/4 transition which had a known ABI issue that impacted native modules, discussed here electron/node-abi#54. We were able to workaround it by blocking clients from trying to download these packages, and I thought I'd upstream this fix to see if you were interested in making this available more broadly for anyone else who happens to stumble into it.In a nutshell, this setup of
prebuildpackages should not be used if they were created:electronruntime4.0.0and4.0.3(inclusive)The patch to
node-abito support this new ABI is now available, so that future prebuild installs will avoid all this drama: electron/node-abi@9e4c1a6