Fix constructing executable path from argv[0] #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…path. Do not call path_isabsolute() in condition -- it always returns 1 and modifies the stack. If argv[0] is already absolute, push it in the stack alone.
Do not leave unwanted stuff in the stack in premake_locate_executable(), as the caller only expects exactly one string to be pushed.
lanurmi
force-pushed
the
fix-locate_executable
branch
from
dbb599e
to
6fe0b64
Compare
samsinsane
approved these changes
Apr 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fallback code for constructing executable path from
argv[0]does not work at all currently. (And possibly never worked?)How to test:
Comment out e.g. the
#if PLATFORM_LINUXblock inpremake_locate_executableinpremake.cand witness the fallback code failing with the error:PANIC: unprotected error in call to Lua API (attemt to call a string value)