Support successfully bootstrapping on OpenBSD. #1070
Conversation
| @@ -365,7 +365,7 @@ int premake_locate_executable(lua_State* L, const char* argv0) | |||
| } | |||
| #endif | |||
|
|
|||
| #if PLATFORM_BSD | |||
| #if PLATFORM_BSD && !defined(__OpenBSD__) | |||
There was a problem hiding this comment.
This seems not great - is there something that can be done to support OpenBSD in this block instead? What does this block do on OpenBSD? I got it working on FreeBSD by adding that sysctl call, is there something similar for OpenBSD?
Sorry to bombard you with questions! I'm keen to see what we can do to improve the BSD situation!
There was a problem hiding this comment.
According to a comment in the latter stackoverflow post referred to in premake_locate_executable()'s comments, OpenBSD does not support other methods than using argv[0]. I'm no expert in *BSD, so I cannot be absolutely sure if this is true. However, that particular piece of code fails to compile on OpenBSD due to the undeclared identifier KERN_PROC_PATHNAME.
There was a problem hiding this comment.
That's fair enough, perhaps wrapping that block instead would be better? Not required, if the none of it will work on OpenBSD it's probably pointless reducing it down to what doesn't compile.
There was a problem hiding this comment.
If only KERN_PROC_PATHNAME was left out on OpenBSD, I don't think the sysctl would do anything meanful anymore even if it would compile; if that's what you meant. Also here's a comment by Theo de Raadt about finding executable path.
There was a problem hiding this comment.
I meant that entire if block that contains the call to sysctl, but it's not really worth the effort. Thanks for the link, it's a pretty interesting discussion.
Bootstrap.mak
Outdated
| @@ -89,7 +89,7 @@ bsd: $(SRC) | |||
| $(CC) -o build/bootstrap/premake_bootstrap -DPREMAKE_NO_BUILTIN_SCRIPTS -DLUA_USE_POSIX -DLUA_USE_DLOPEN -I"$(LUA_DIR)" -I"$(LUASHIM_DIR)" $? -lm | |||
| ./build/bootstrap/premake_bootstrap embed | |||
| ./build/bootstrap/premake_bootstrap --to=build/bootstrap gmake | |||
| $(MAKE) -C build/bootstrap -j`getconf _NPROCESSORS_ONLN` config=$(CONFIG) | |||
| $(MAKE) -C build/bootstrap -j`getconf _NPROCESSORS_ONLN || getconf NPROCESSORS_ONLN` config=$(CONFIG) | |||
There was a problem hiding this comment.
Would it be possible to remove _NPROCESSORS_ONLN or does this depend on the BSD flavour?
There was a problem hiding this comment.
Actually, it seems _NPROCESSORS_ONLN doesn't work on FreeBSD either; so the underscore-less variant would be fine for both OpenBSD and FreeBSD. But as someone else added the variant with underscore in the first place, dunno if it actually works on some *BSD.
There was a problem hiding this comment.
That would have been me, I just copied the Linux one and it built the project, I didn't investigate the value. If it doesn't work on your FreeBSD it likely didn't work on mine, I think we should remove the underscore version. 👍
There was a problem hiding this comment.
Yeah, when it doesn't work it is not easily noticeable with GNU Make, as it accepts -j without a numeric value too, and the build doesn't fail. I was (unintentionally) using a non-gnu make on OpenBSD, which then failed because it requires a value for -j. And yes I agree, the underscore version should be removed.
There was a problem hiding this comment.
Cool, can you remove it in this PR? We can merge this once you've done that. 😄
|
I tried compiling also on NetBSD, but encountered way more fundamental errors (such as compiler not supporting |
lanurmi
force-pushed
the
fix-openbsd-depends-on-1068
branch
from
63a83af
to
e71a99d
Compare
This PR depends on PR #1068, which should be applied first.