Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(HOCs): withFirestore doesn't provide firebase anymore #606

Closed
cgestes opened this issue Jan 4, 2019 · 3 comments
Closed

bug(HOCs): withFirestore doesn't provide firebase anymore #606

cgestes opened this issue Jan 4, 2019 · 3 comments
Assignees
@prescottprue
Labels
bug
Milestone
v3.0.*

Comments

@cgestes
Copy link

cgestes commented Jan 4, 2019

Do you want to request a feature or report a bug?
not sure if this is a feature or a request!

withFirestore only set firestore on branch 'next'. It used to set dispatch and firebase also.

The obvious fix is to use withFirebase to get firebase.

I guess, we could either document it in the migration guide or fix it :)
@prescottprue
Copy link
Owner

prescottprue commented Jan 4, 2019 •
edited
Loading

We should definitely fix it! I think firestoreConnect may also still need a little more love too. Thanks for reporting.

Which version did you install from next?

@cgestes
Copy link
Author

cgestes commented Jan 10, 2019 •
edited
Loading

it was 3.0.0-alpha5 :)

@prescottprue
Copy link
Owner

@cgestes Great to know - I'll look into the fix

@prescottprue prescottprue self-assigned this Jan 15, 2019
@prescottprue prescottprue changed the title [next] withFirestore doesn't provide firebase anymore bug(HOCs): withFirestore doesn't provide firebase anymore Jan 15, 2019
@prescottprue prescottprue added this to the v3.0.* milestone Jan 15, 2019
prescottprue added a commit that referenced this issue Jan 16, 2019
@prescottprue
fix(HOCs): missing props (firebase + dispatch) added - #606
4c9c0c0
@prescottprue prescottprue mentioned this issue Jan 16, 2019
Merged
3 tasks
prescottprue added a commit that referenced this issue Feb 5, 2019
@prescottprue
v3.0.0-alpha.7
79178bb 
* fix(firebaseConnect): rename internal props and throw for name collisions - #613 - @theashguy + @iamthefox
* fix(HOCs): missing props (firebase + dispatch) added - #606
* feat(typings): major upgrade to typescript definitions (including types from `@firebase`) - #627 - @rscotten
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prescottprue prescottprue

Labels
bug
Projects
None yet
Milestone
v3.0.*
Development

No branches or pull requests
2 participants
@cgestes @prescottprue