feat(typings): major improvement to typescript definitions (including types from @firebase) #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #627 +/- ##
=======================================
Coverage 78.61% 78.61%
=======================================
Files 26 26
Lines 926 926
Branches 166 166
=======================================
Hits 728 728
Misses 198 198 |
|
So much detail in here, thanks |
prescottprue
changed the title
|
@rscotten I will clean this up later because some types are not needed and provided by firebase, for example |
|
@idanlo yeah, I'm merging in your changes right now. Lots of good stuff in your version. I'll have another PR ready by end of day |
prescottprue
added a commit
that referenced
this pull request
Feb 5, 2019
* fix(firebaseConnect): rename internal props and throw for name collisions - #613 - @theashguy + @iamthefox * fix(HOCs): missing props (firebase + dispatch) added - #606 * feat(typings): major upgrade to typescript definitions (including types from `@firebase`) - #627 - @rscotten
|
I went ahead and released v3.0.0-alpha.7 with those changes (since there were other features going out anyway). Any updates either of you make in new PR(s) I'll make sure to try to get released quickly. Thanks again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check List
If not relevant to pull request, check off as complete
(n/a) Docs updated with any changes or examples if applicable
(n/a) Added tests to ensure new feature(s) work properly
Relevant Issues
Types are incomplete but an improvement