Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting context #517

Merged
merged 3 commits into from
Jun 16, 2023
Merged

Conversation

ori-shalom
Copy link
Contributor

@ori-shalom ori-shalom commented May 8, 2023

Closes #513
This PR adds for all public methods that access the DB a version that receives context.Context.
The old methods that don't receive context.Context are still available for backward compatibility.

@mfridman mfridman self-requested a review May 17, 2023 13:17
@mfridman mfridman added this to the Up next in v3 milestone May 17, 2023
migrate.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@mfridman mfridman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks for plumbing this through 🎉

@mfridman mfridman merged commit 7dcddde into pressly:master Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting context for goose operations
2 participants