Receive context in migrations #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Hi @mfridman, by any chance can you review this PR too so adding context support to v3 will be complete? |
mfridman
reviewed
Jun 29, 2023
| if err != nil { | ||
| return -1, err | ||
| } | ||
|
|
||
| return version, nil | ||
| } | ||
|
|
||
| // withContext changes the signature of a function that receives one argument to receive a context and the argument. | ||
| func withContext[T any](fn func(T) error) func(context.Context, T) error { |
@ori-shalom Sure, can you please rebase this PR? |
|
Actually, I'll merge this and make a few comment updates. Thanks for a clean implementation, looks sane to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to PR #517.
It's currently based on top of
piiano:feat/allow-setting-contextso when #517 will get merged I'll rebase it.This PR allows defining migrations that receive context.
Old migrations that don't receive
context.Contextwill still continue to work for backward compatibility.The generation of new Go migrations changed to generate migrations that receive context.