Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix schema mismatch w/Parquet INT64 & Timestamp #13857

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Fix schema mismatch w/Parquet INT64 & Timestamp #13857

merged 1 commit into from
Dec 12, 2019
+10 −1

Conversation

aweisberg
Copy link
Contributor

Schema checks are too strict and prevent timestamp type from being read as int64 from Parquet files.
Fixes: #13855

== RELEASE NOTES ==
Parquet Changes
* Fix schema mismatch w/Parquet INT64 & Timestamp

@aweisberg aweisberg self-assigned this Dec 12, 2019
@aweisberg
Copy link
Contributor Author

@arhimondr Does this not go far enough? Should all the other timestamp types that inherit from abstract long type work as well?

@arhimondr
Copy link
Member

@aweisberg You mean the Timestamp With Time Zone?

@arhimondr arhimondr merged commit bb17af3 into prestodb:master Dec 12, 2019
@aweisberg
Copy link
Contributor Author

Turns out Hive only supports Timestamp so no further changes were required.

@aweisberg aweisberg mentioned this pull request Jan 17, 2020
Closed
7 tasks
@caithagoras caithagoras mentioned this pull request Jan 22, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhimondr arhimondr arhimondr approved these changes

@zhenxiao zhenxiao Awaiting requested review from zhenxiao

Assignees

@aweisberg aweisberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reading timestamp with type INT64 in Parquet file fails
2 participants
@aweisberg @arhimondr