Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor IcebergAbstractMetadata to utilize newly defined SPI method #22384

Merged

Conversation

hantangwangd
Copy link
Member

Description

PR #21933 has deprecated SPI method ConnectorMetadata.getTableLayouts(), and introduced a new SPI method ConnectorMetadata.getTableLayoutForConstraint() to replace it.

This PR refactor IcebergAbstractMetadata to utilize the newly defined SPI method, and stop to use the deprecated method.

Motivation and Context

Make the implementation in IcebergAbstractMetadata more clear and concise

Test Plan

  • Make sure the refactor do not affect existing test cases

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@hantangwangd hantangwangd requested a review from a team as a code owner April 1, 2024 13:22
Copy link
Contributor

@tdcmeehan tdcmeehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the cleanup

@hantangwangd hantangwangd merged commit 402b6da into prestodb:master Apr 1, 2024
56 checks passed
@hantangwangd hantangwangd deleted the refactor_iceberg_metadata branch April 1, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants