Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor IcebergAbstractMetadata to utilize newly defined SPI method #22384

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Refactor IcebergAbstractMetadata to utilize newly defined SPI method #22384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergAbstractMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,10 +200,10 @@ protected final Table getIcebergTable(ConnectorSession session, SchemaTableName
protected abstract void unregisterTable(ConnectorSession clientSession, SchemaTableName schemaTableName);

/**
* This class implements the default implementation for getTableLayouts which will be used in the case of a Java Worker
* This class implements the default implementation for getTableLayoutForConstraint which will be used in the case of a Java Worker
*/
@Override
public List<ConnectorTableLayoutResult> getTableLayouts(
public ConnectorTableLayoutResult getTableLayoutForConstraint(
ConnectorSession session,
ConnectorTableHandle table,
Constraint<ColumnHandle> constraint,
Expand Down Expand Up @@ -233,7 +233,7 @@ public List<ConnectorTableLayoutResult> getTableLayouts(
.setPartitions(Optional.empty())
.setTable(handle)
.build());
return ImmutableList.of(new ConnectorTableLayoutResult(layout, constraint.getSummary()));
return new ConnectorTableLayoutResult(layout, constraint.getSummary());
}

public static Subfield toSubfield(ColumnHandle columnHandle)
Expand Down
Loading