Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(html): support ie conditional start/end comment #5470

Merged
merged 8 commits into from
Nov 15, 2018
Merged

feat(html): support ie conditional start/end comment #5470

merged 8 commits into from
Nov 15, 2018

Conversation

ikatyang
Copy link
Member

Fixes #5459

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@ikatyang ikatyang changed the title feat: support ie conditional start/end comment feat(html): support ie conditional start/end comment Nov 14, 2018
@ikatyang ikatyang merged commit 668e049 into prettier:master Nov 15, 2018
@ikatyang ikatyang deleted the fix/html/ie-conditional-start-end-comment branch November 15, 2018 04:35
@ikatyang ikatyang added this to the 1.15.3 milestone Nov 23, 2018
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Feb 21, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Milestone
1.15.3
Development

Successfully merging this pull request may close these issues.
2 participants
@ikatyang @alexander-akait