Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(html): do not format non-normal whitespaces as normal whitespaces #5797

Merged
merged 5 commits into from
Jan 30, 2019
Merged

fix(html): do not format non-normal whitespaces as normal whitespaces #5797

merged 5 commits into from
Jan 30, 2019

Conversation

ikatyang
Copy link
Member

Fixes #5796

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If not an internal change) I’ve added my changes to the CHANGELOG.unreleased.md file following the template.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@ikatyang ikatyang requested a review from a team January 28, 2019 01:42
@ikatyang ikatyang added this to the 1.16.2 milestone Jan 28, 2019
@lydell
Copy link
Member

lydell commented Jan 28, 2019

Looks good to me. Does the HTML spec say anything about this?

@ikatyang ikatyang merged commit 847a78e into prettier:master Jan 30, 2019
@ikatyang ikatyang deleted the fix/html/non-breaking-narrow-whitespace branch January 30, 2019 06:30
@automatops automatops mentioned this pull request Jan 30, 2019
Merged
1 task
@ghost ghost mentioned this pull request Jan 30, 2019
Merged
1 task
@xcomponentadmin xcomponentadmin mentioned this pull request Jan 30, 2019
Merged
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Apr 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@suchipi suchipi suchipi approved these changes

@lipis lipis lipis approved these changes

Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Milestone
1.16.2
Development

Successfully merging this pull request may close these issues.

Prettier kills non-breaking spaces in HTML and angular
4 participants
@ikatyang @lydell @lipis @suchipi