Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Link styles to PVC #1616

Closed
wants to merge 4 commits into from
Closed

Move Link styles to PVC #1616

wants to merge 4 commits into from

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Nov 18, 2022

Description

This is part of #1342 and adds the Link styles from PCSS. There should be no visual changes.

Integration

Does this change require any updates to code in production?

Yes, the following line can be removed on dotcom:

- @import '@primer/css/links/link.scss';

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews
  • Visual regression test
Before After
image image

@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2022

🦋 Changeset detected

Latest commit: 942afda

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the css Pull requests that update CSS code label Nov 18, 2022
@simurai simurai temporarily deployed to github-pages November 18, 2022 06:40 Inactive
@simurai simurai marked this pull request as ready for review November 18, 2022 06:56
@simurai simurai requested a review from a team as a code owner November 18, 2022 06:56
@simurai simurai requested review from a team, tobiasahlin and keithamus November 18, 2022 06:56
@simurai
Copy link
Contributor Author

simurai commented Nov 21, 2022

This will be superseded by #1620.

@simurai simurai closed this Nov 21, 2022
@simurai simurai deleted the link-pcss branch November 21, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css Pull requests that update CSS code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant