Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Link and ButtonMarketing styles to PVC #1620

Merged
merged 21 commits into from
Nov 21, 2022
Merged

Move Link and ButtonMarketing styles to PVC #1620

merged 21 commits into from
Nov 21, 2022

Conversation

mxriverlynn
Copy link
Contributor

@mxriverlynn mxriverlynn commented Nov 18, 2022 •
edited
Loading

Description

pulling component specific css source from Primer CSS, into PVC

  • marketing button
  • link

this PR also organizes the IGNORED_SELECTORS in test/css/component_selector_use_test.rb

Merge checklist

  • Added/updated tests
  • Added/updated previews

@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: c255eaa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the css Pull requests that update CSS code label Nov 18, 2022
@mxriverlynn mxriverlynn temporarily deployed to review-pr-1620 November 18, 2022 17:08 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2022 •
edited
Loading

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@jonrohan
Copy link
Member

The visual diff here alarmed me, but I think I broke an import in lookbook that stopped rendering the image, so you're actually fixing the bug 😅

I double checked on github and it's still looking like expected

@mxriverlynn mxriverlynn changed the title [WIP] pulling in some primer css Moving CSS for Link and Marketing Button, to PVC Nov 18, 2022
@mxriverlynn mxriverlynn temporarily deployed to github-pages November 18, 2022 18:45 Inactive
@mxriverlynn mxriverlynn temporarily deployed to review-pr-1620 November 18, 2022 18:47 Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages November 18, 2022 18:52 Inactive
@mxriverlynn mxriverlynn requested review from a team, tobiasahlin and jonrohan November 18, 2022 20:23
@mxriverlynn
Copy link
Contributor Author

@jonrohan assuming the visual difference is expected / correct, this is ready for review now

@jonrohan
Copy link
Member

I'm gonna let @simurai review this one since he's done a few of them already. But he's out for the weekend already and will probably take a look monday morning.

simurai
simurai requested changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The $font-weight-bold still needs to be replaced. Otherwise looks good. ✨

app/components/primer/alpha/button_marketing.pcss Outdated Show resolved Hide resolved
@simurai simurai mentioned this pull request Nov 21, 2022
Closed
4 tasks
@mxriverlynn @simurai
Update app/components/primer/alpha/button_marketing.pcss
0ee0f79 
Co-authored-by: simurai <simurai@github.com>
@mxriverlynn mxriverlynn force-pushed the mxriverlynn/component-css-from-primer-css branch from 8f5f84f to d8647a0 Compare November 21, 2022 13:57
@mxriverlynn mxriverlynn temporarily deployed to review-pr-1620 November 21, 2022 13:58 Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages November 21, 2022 14:02 Inactive
@mxriverlynn mxriverlynn enabled auto-merge (squash) November 21, 2022 14:11
@mxriverlynn mxriverlynn temporarily deployed to review-pr-1620 November 21, 2022 20:00 Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages November 21, 2022 20:04 Inactive
@mxriverlynn mxriverlynn changed the title Moving CSS for Link and Marketing Button, to PVC Moving Link and ButtonMarketing styles to PVC Nov 21, 2022
@mxriverlynn mxriverlynn changed the title Moving Link and ButtonMarketing styles to PVC Move Link and ButtonMarketing styles to PVC Nov 21, 2022
@mxriverlynn mxriverlynn temporarily deployed to github-pages November 21, 2022 20:36 Inactive
simurai
simurai approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@mxriverlynn mxriverlynn merged commit 4898307 into main Nov 21, 2022
@mxriverlynn mxriverlynn deleted the mxriverlynn/component-css-from-primer-css branch November 21, 2022 23:37
@primer-css primer-css mentioned this pull request Nov 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simurai simurai simurai approved these changes

@tobiasahlin tobiasahlin Awaiting requested review from tobiasahlin tobiasahlin is a code owner automatically assigned from primer/css-reviewers

@jonrohan jonrohan Awaiting requested review from jonrohan

Assignees
No one assigned
Labels
css Pull requests that update CSS code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mxriverlynn @jonrohan @simurai