Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to address #9. #25

Merged
merged 10 commits into from
Apr 14, 2020
Merged

Try to address #9. #25

merged 10 commits into from
Apr 14, 2020

Conversation

hober
Copy link
Member

@hober hober commented Apr 9, 2020

This is a strawman fix for #9 to facilitate discussion. It builds on #23, and contains the following changes:

  • Defines the role of a proposal champion (like in TC39). Champions are to Proposals as Editors are to Specifications.
  • Removes the clause about removing proposals because they lack multi-implementer support.
  • Changes how proposals get adopted as specifications. Some new wording, and some ideas from jyasskin/privacycg.github.io
  • Removes the clauses about specification feature additions and removals.
  • Removes the clause about objecting to an editors' decision solely because it lacks multiple-implementer support
  • Removes the definition of implementer.

@hober hober added do not merge This PR is a work in progress and is not ready to be merged charter labels Apr 9, 2020
Copy link
Contributor

@cwilso cwilso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks great. One typo, a couple of optional comments.

charter.html Outdated Show resolved Hide resolved
charter.html Show resolved Hide resolved
charter.html Show resolved Hide resolved
charter.html Outdated Show resolved Hide resolved
charter.html Outdated Show resolved Hide resolved
charter.html Outdated Show resolved Hide resolved
charter.html Outdated Show resolved Hide resolved
Copy link

@othermaciej othermaciej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I raised some nitpicky points, but essentially, I think this does the right thing and upholds everyone's goals for how this group should operate.

charter.html Outdated Show resolved Hide resolved
charter.html Show resolved Hide resolved
Copy link
Member

@TanviHacks TanviHacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good!

Can we separate out the change from "Work Item" to "Specification" that are in https://github.com/privacycg/privacycg.github.io/pull/23/files? We can discuss those changes separately.

Copy link

@dbaron dbaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modulo the comments from @TanviHacks this looks good to me as well

@hober
Copy link
Member Author

hober commented Apr 13, 2020

@TanviHacks asked:

Can we separate out the change from "Work Item" to "Specification" that are in https://github.com/privacycg/privacycg.github.io/pull/23/files? We can discuss those changes separately.

I'll prepare a separate PR for the Work Item version of this, once we've ironed out all of the details here.

@hober
Copy link
Member Author

hober commented Apr 13, 2020

Okay, I think I've addressed all of the outstanding comments on this.

Please take another, hopefully final, look @cwilso @othermaciej @dbaron @TanviHacks @erik-anderson!

@erik-anderson
Copy link
Member

Thanks @hober! The latest changes look good to me. I am okay with splitting out the "Work Item to Specification terminology change" to a separate PR. I will approve this PR after that change is made.

@cwilso
Copy link
Contributor

cwilso commented Apr 14, 2020

Thanks @hober! LGTM.

@hober hober merged commit e8d2ac9 into call-them-specs Apr 14, 2020
@hober hober deleted the hober-issue-9 branch April 14, 2020 20:34
@hober
Copy link
Member Author

hober commented Apr 14, 2020

Now that #26 is up, I've merged this into #23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
charter do not merge This PR is a work in progress and is not ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants