-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to address #9. #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks great. One typo, a couple of optional comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I raised some nitpicky points, but essentially, I think this does the right thing and upholds everyone's goals for how this group should operate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good!
Can we separate out the change from "Work Item" to "Specification" that are in https://github.com/privacycg/privacycg.github.io/pull/23/files? We can discuss those changes separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modulo the comments from @TanviHacks this looks good to me as well
@TanviHacks asked:
I'll prepare a separate PR for the Work Item version of this, once we've ironed out all of the details here. |
Okay, I think I've addressed all of the outstanding comments on this. Please take another, hopefully final, look @cwilso @othermaciej @dbaron @TanviHacks @erik-anderson! |
Thanks @hober! The latest changes look good to me. I am okay with splitting out the "Work Item to Specification terminology change" to a separate PR. I will approve this PR after that change is made. |
Thanks @hober! LGTM. |
This is a strawman fix for #9 to facilitate discussion. It builds on #23, and contains the following changes: