-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define storage access to be per-page. Handle when the user doesn't explicitly allow or deny. Fixes #3. Fixes #26. #27
Conversation
…the storage access map. Use them.
The change regarding #26 LGTM. |
Thinking about this some more, I think what's missing here is some caching of this state on agent clusters or some such. In particular, imagine the user opens So site-b in 1 requests storage access and gets it. If site-b in 2 does |
I think you're right. I'd like to address this in a followup patch, if that's okay. |
Sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. None of my comments are blocking.
No description provided.