Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt to the type change in Gen from AddressSet to Selection #10

Merged

Conversation

hhaensel
Copy link
Contributor

@hhaensel hhaensel commented Aug 6, 2019

This tackles the issue #9 by changing the type according to https://github.com/probcomp/Gen/pull/100

@hhaensel hhaensel changed the title adapt to the type change in Gen from AdressSet to Selection adapt to the type change in Gen from AddressSet to Selection Aug 6, 2019
@fsaad
Copy link
Collaborator

fsaad commented Aug 6, 2019

@hhaensel Thank you for the PR!

@alex-lew I think that the Travis CI tests are failing because the version of Gen that is being used (0.3.1) does not contain the patch https://github.com/probcomp/Gen/pull/100 that renamed AddressSet to Selection. The users who reported the issue #9 were possibly using the version of Gen from master. My guess is that the Travis tests will pass after we create a new Gen release, 0.3.2 and then update the dependency in Manifest.toml:

version = "0.3.1"

…sible to point PyCall to a virtualenv. So let's just use `PyCall.pyimport_conda`.
…efore needing to rework the code to work with the latest TensorFlow are numbered, but that number is currently positive.
…CI is ok with the previous way so let's keep the changes minimal.
@bzinberg
Copy link
Contributor

bzinberg commented Feb 4, 2020

Disabled eager execution (which is enabled by default in TF 2.x) and changed a bunch of TF1 references to tf.compat.v1.

The tests now pass for me locally, and are timing out on CI. I think this is because the longer Travis timeout on probcomp's pro account does not apply to @hhaensel's fork. So I'm going to move these to a branch on the main repo.

@bzinberg bzinberg changed the base branch from master to 20200204-update-dependencies February 4, 2020 23:19
@bzinberg bzinberg merged commit f310e3b into probcomp:20200204-update-dependencies Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants